Skip to content

fix: coderd/prometheusmetrics wait for all metrics in require.Eventually #5338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix: coderd/prometheusmetrics wait for all metrics in require.Eventually #5338

merged 1 commit into from
Dec 7, 2022

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Dec 7, 2022

Fixes: #5323

There is a bug in the test causing some flakiness. The test should wait until all metrics have been reported and don't fail the require routine in the meantime.

@mtojek mtojek marked this pull request as ready for review December 7, 2022 16:08
@mtojek mtojek requested a review from a team December 7, 2022 16:08
@deansheather deansheather requested a review from coadler December 7, 2022 16:46
@mtojek mtojek merged commit 534bff2 into coder:main Dec 7, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@coadler coadler coadler approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky: coderd/prometheusmetrics TestWorkspaces/Multiple
2 participants
@mtojek @coadler