Linting

Emyrk · Emyrk · commit 558ef48d97f8 · 2023-05-31T10:48:10.000-04:00
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -569,6 +569,7 @@ func TestWorkspaceFilterAllStatus(t *testing.T) {
 		t.Skip(`This test takes too long with an actual database. Takes 10s on local machine`)
 	}
 
+	// nolint:gocritic -- unit testing
 	ctx := dbauthz.AsSystemRestricted(context.Background())
 	db, pubsub := dbtestutil.NewDB(t)
 	client := coderdtest.New(t, &coderdtest.Options{
@@ -743,7 +744,6 @@ func TestWorkspaceFilterAllStatus(t *testing.T) {
 	// Now test the filter
 	for _, status := range statuses {
 		ctx, cancel := context.WithTimeout(ctx, testutil.WaitShort)
-		defer cancel()
 
 		workspaces, err := client.Workspaces(ctx, codersdk.WorkspaceFilter{
 			Status: string(status),
@@ -752,6 +752,7 @@ func TestWorkspaceFilterAllStatus(t *testing.T) {
 		for _, workspace := range workspaces.Workspaces {
 			assert.Equal(t, status, workspace.LatestBuild.Status, "expect matching status to filter")
 		}
+		cancel()
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -569,6 +569,7 @@ func TestWorkspaceFilterAllStatus(t *testing.T) {`
`569`	`569`	t.Skip(`This test takes too long with an actual database. Takes 10s on local machine`)
`570`	`570`	`}`
`571`	`571`
	`572`	`+ // nolint:gocritic -- unit testing`
`572`	`573`	`ctx := dbauthz.AsSystemRestricted(context.Background())`
`573`	`574`	`db, pubsub := dbtestutil.NewDB(t)`
`574`	`575`	`client := coderdtest.New(t, &coderdtest.Options{`
`@@ -743,7 +744,6 @@ func TestWorkspaceFilterAllStatus(t *testing.T) {`
`743`	`744`	`// Now test the filter`
`744`	`745`	`for _, status := range statuses {`
`745`	`746`	`ctx, cancel := context.WithTimeout(ctx, testutil.WaitShort)`
`746`		`- defer cancel()`
`747`	`747`
`748`	`748`	`workspaces, err := client.Workspaces(ctx, codersdk.WorkspaceFilter{`
`749`	`749`	`Status: string(status),`
`@@ -752,6 +752,7 @@ func TestWorkspaceFilterAllStatus(t *testing.T) {`
`752`	`752`	`for _, workspace := range workspaces.Workspaces {`
`753`	`753`	`assert.Equal(t, status, workspace.LatestBuild.Status, "expect matching status to filter")`
`754`	`754`	`}`
	`755`	`+ cancel()`
`755`	`756`	`}`
`756`	`757`	`}`
`757`	`758`