chore: add hard cutoff for waitFor calls

Parkreiner · Parkreiner · commit 56873b80d701 · 2023-09-20T17:09:03.000Z
diff --git a/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx b/site/src/pages/TemplateSettingsPage/TemplateSchedulePage/TemplateSchedulePage.test.tsx
@@ -1,4 +1,4 @@
-import { screen, waitFor } from "@testing-library/react";
+import { screen, waitFor, type waitForOptions } from "@testing-library/react";
 import userEvent from "@testing-library/user-event";
 import * as API from "api/api";
 import { Language as FooterFormLanguage } from "components/FormFooter/FormFooter";
@@ -103,6 +103,12 @@ const fillAndSubmitForm = async ({
   await user.click(confirmButton);
 };
 
+const waitForConfig = {
+  // Test averages about 13 seconds to complete; adding an extra three to
+  // account for spikes before definitely failing a test
+  timeout: 16_000,
+} as const satisfies waitForOptions;
+
 describe("TemplateSchedulePage", () => {
   beforeEach(() => {
     jest
@@ -121,7 +127,10 @@ describe("TemplateSchedulePage", () => {
     });
 
     await fillAndSubmitForm(validFormValues);
-    await waitFor(() => expect(API.updateTemplateMeta).toBeCalledTimes(1));
+    await waitFor(
+      () => expect(API.updateTemplateMeta).toBeCalledTimes(1),
+      waitForConfig,
+    );
   });
 
   test("default and max ttl is converted to and from hours", async () => {
@@ -133,16 +142,20 @@ describe("TemplateSchedulePage", () => {
     });
 
     await fillAndSubmitForm(validFormValues);
-    await waitFor(() => expect(API.updateTemplateMeta).toBeCalledTimes(1));
-    await waitFor(() =>
+    await waitFor(
+      () => expect(API.updateTemplateMeta).toBeCalledTimes(1),
+      waitForConfig,
+    );
+
+    await waitFor(() => {
       expect(API.updateTemplateMeta).toBeCalledWith(
         "test-template",
         expect.objectContaining({
           default_ttl_ms: (validFormValues.default_ttl_ms || 0) * 3600000,
           max_ttl_ms: (validFormValues.max_ttl_ms || 0) * 3600000,
         }),
-      ),
-    );
+      );
+    }, waitForConfig);
   });
 
   test("failure, dormancy, and dormancy auto-deletion converted to and from days", async () => {
@@ -154,8 +167,12 @@ describe("TemplateSchedulePage", () => {
     });
 
     await fillAndSubmitForm(validFormValues);
-    await waitFor(() => expect(API.updateTemplateMeta).toBeCalledTimes(1));
-    await waitFor(() =>
+    await waitFor(
+      () => expect(API.updateTemplateMeta).toBeCalledTimes(1),
+      waitForConfig,
+    );
+
+    await waitFor(() => {
       expect(API.updateTemplateMeta).toBeCalledWith(
         "test-template",
         expect.objectContaining({
@@ -165,8 +182,8 @@ describe("TemplateSchedulePage", () => {
           time_til_dormant_autodelete_ms:
             (validFormValues.time_til_dormant_autodelete_ms || 0) * 86400000,
         }),
-      ),
-    );
+      );
+    }, waitForConfig);
   });
 
   it("allows a default ttl of 7 days", () => {
