format

aslilac · aslilac · commit 5c0292b2ffb1 · 2024-08-14T22:22:56.000Z
diff --git a/site/src/api/api.ts b/site/src/api/api.ts
@@ -992,8 +992,8 @@ class ApiMethods {
         let latestJobInfo: TypesGen.ProvisionerJob | undefined = undefined;
 
         while (
-          !["succeeded", "canceled"].some(
-            (status) => latestJobInfo?.status.includes(status),
+          !["succeeded", "canceled"].some((status) =>
+            latestJobInfo?.status.includes(status),
           )
         ) {
           const { job } = await this.getWorkspaceBuildByNumber(
diff --git a/site/src/pages/TemplateSettingsPage/TemplateVariablesPage/TemplateVariablesForm.tsx b/site/src/pages/TemplateSettingsPage/TemplateVariablesPage/TemplateVariablesForm.tsx
@@ -157,26 +157,27 @@ const ValidationSchemaForTemplateVariables = (
     .of(
       Yup.object().shape({
         name: Yup.string().required(),
-        value: Yup.string().test("verify with template", (val, ctx) => {
-          const name = ctx.parent.name;
-          const templateVariable = templateVariables.find(
-            (variable) => variable.name === name,
-          );
-          if (templateVariable?.sensitive) {
-            // It's possible that the secret is already stored in database,
-            // so we can't properly verify the "required" condition.
-            return true;
-          }
-          if (templateVariable?.required) {
-            if (!val || val.length === 0) {
-              return ctx.createError({
-                path: ctx.path,
-                message: "Variable is required.",
-              });
+        value: Yup.string()
+          .test("verify with template", (val, ctx) => {
+            const name = ctx.parent.name;
+            const templateVariable = templateVariables.find(
+              (variable) => variable.name === name,
+            );
+            if (templateVariable?.sensitive) {
+              // It's possible that the secret is already stored in database,
+              // so we can't properly verify the "required" condition.
+              return true;
             }
-          }
-          return true;
-        }),
+            if (templateVariable?.required) {
+              if (!val || val.length === 0) {
+                return ctx.createError({
+                  path: ctx.path,
+                  message: "Variable is required.",
+                });
+              }
+            }
+            return true;
+          }),
       }),
     )
     .required();
