revert change to coderdtest, see #14417 for correct fix

johnstcn · johnstcn · commit 5f9dbfef2cbc · 2024-08-23T15:16:15.000+01:00
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -270,7 +270,7 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can
 	}
 	// This value is not safe to run in parallel.
 	if options.DeploymentValues.DisableOwnerWorkspaceExec.Value() && testutil.IsParallel(t) {
-		t.Fatal("DisableOwnerWorkspaceExec is set, this is not safe in parallel tests!")
+		t.Logf("WARNING: DisableOwnerWorkspaceExec is set, this is not safe in parallel tests!")
 	}
 
 	// If no ratelimits are set, disable all rate limiting for tests.

Original file line number	Diff line number	Diff line change
`@@ -270,7 +270,7 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can`
`270`	`270`	`}`
`271`	`271`	`// This value is not safe to run in parallel.`
`272`	`272`	`if options.DeploymentValues.DisableOwnerWorkspaceExec.Value() && testutil.IsParallel(t) {`
`273`		`- t.Fatal("DisableOwnerWorkspaceExec is set, this is not safe in parallel tests!")`
	`273`	`+ t.Logf("WARNING: DisableOwnerWorkspaceExec is set, this is not safe in parallel tests!")`
`274`	`274`	`}`
`275`	`275`
`276`	`276`	`// If no ratelimits are set, disable all rate limiting for tests.`