Skip to content

Commit 5fa2b96

Browse files
Apply suggestions from code review
Co-authored-by: Cian Johnston <cian@coder.com>
1 parent cf25746 commit 5fa2b96

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

coderd/rbac/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ This can be represented by the following truth table, where Y represents _positi
4949
- `object` is any valid resource type.
5050
- `id` is any valid UUID v4.
5151
- `id` is included in the permission syntax, however only scopes may use `id` to specify a specific object.
52-
- `action` is `create`, `read`, `modify`, `delete`, or another verb.
52+
- `action` is typically `create`, `read`, `modify`, `delete`, but you can define other verbs as needed.
5353

5454
## Example Permissions
5555

coderd/rbac/USAGE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ Let's now add our frobulator noun to `coderd/rbac/policy/policy.go`:
103103
...
104104
```
105105

106-
Entries in the `frobulators` table be created/read/updated/deleted, so we define
106+
We need to create/read/update/delete rows in the `frobulators` table, so we define
107107
those actions.
108108

109109
`policy.go` is used to generate code in `coderd/rbac/object_gen.go`, and we can
@@ -288,7 +288,7 @@ FAIL
288288
This shows you that the `org_auditor` role has `read` permissions on the
289289
frobulator, but no test case covered it.
290290

291-
**NOTE: don't just add cases which make the tests pass; consider all the way in
291+
**NOTE: don't just add cases which make the tests pass; consider all the ways in
292292
which your resource must be used, and test all of those scenarios!**
293293
294294
# Database authorization

0 commit comments

Comments
 (0)