Skip to content

Commit 6126e6b

Browse files
committed
usersByIDs
1 parent 0cdf3ea commit 6126e6b

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

coderd/notifications/reports/generator.go

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -256,29 +256,31 @@ func findTemplateAdmins(ctx context.Context, db database.Store, stats database.G
256256
return nil, xerrors.Errorf("unable to fetch template admins: %w", err)
257257
}
258258

259+
var templateAdmins []database.GetUsersRow
260+
259261
usersByIDs := map[uuid.UUID]database.GetUsersRow{}
262+
if len(usersByIDs) == 0 {
263+
return templateAdmins, nil
264+
}
265+
260266
var userIDs []uuid.UUID
261267
for _, user := range users {
262268
usersByIDs[user.ID] = user
263269
userIDs = append(userIDs, user.ID)
264270
}
265271

266-
var templateAdmins []database.GetUsersRow
267-
if len(userIDs) > 0 {
268-
orgIDsByMemberIDs, err := db.GetOrganizationIDsByMemberIDs(ctx, userIDs)
269-
if err != nil {
270-
return nil, xerrors.Errorf("unable to fetch organization IDs by member IDs: %w", err)
271-
}
272+
orgIDsByMemberIDs, err := db.GetOrganizationIDsByMemberIDs(ctx, userIDs)
273+
if err != nil {
274+
return nil, xerrors.Errorf("unable to fetch organization IDs by member IDs: %w", err)
275+
}
272276

273-
for _, entry := range orgIDsByMemberIDs {
274-
if slices.Contains(entry.OrganizationIDs, stats.TemplateOrganizationID) {
275-
templateAdmins = append(templateAdmins, usersByIDs[entry.UserID])
276-
}
277+
for _, entry := range orgIDsByMemberIDs {
278+
if slices.Contains(entry.OrganizationIDs, stats.TemplateOrganizationID) {
279+
templateAdmins = append(templateAdmins, usersByIDs[entry.UserID])
277280
}
278281
}
279282
sort.Slice(templateAdmins, func(i, j int) bool {
280283
return templateAdmins[i].Username < templateAdmins[j].Username
281284
})
282-
283285
return templateAdmins, nil
284286
}

0 commit comments

Comments
 (0)