Fix up additional floating promise cases

bryphe-coder · bryphe-coder · commit 61af313fd1b5 · 2022-01-22T04:10:08.000Z
diff --git a/site/components/SignIn/SignInForm.tsx b/site/components/SignIn/SignInForm.tsx
@@ -88,7 +88,7 @@ export const SignInForm: React.FC<SignInProps> = ({
         await loginHandler(email, password)
         // Tell SWR to invalidate the cache for the user endpoint
         await mutate("/api/v2/user")
-        router.push("/")
+        await router.push("/")
       } catch (err) {
         helpers.setFieldError("password", "The username or password is incorrect.")
       }
diff --git a/site/contexts/UserContext.tsx b/site/contexts/UserContext.tsx
@@ -23,7 +23,9 @@ export const useUser = (redirectOnError = false): UserContext => {
   const requestError = ctx.error
   useEffect(() => {
     if (redirectOnError && requestError) {
-      router.push({
+      // 'void' means we are ignoring handling the promise returned
+      // from router.push (and lets the linter know we're OK with that!)
+      void router.push({
         pathname: "/login",
         query: {
           redirect: router.asPath,

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ export const SignInForm: React.FC<SignInProps> = ({`
`88`	`88`	`await loginHandler(email, password)`
`89`	`89`	`// Tell SWR to invalidate the cache for the user endpoint`
`90`	`90`	`await mutate("/api/v2/user")`
`91`		`- router.push("/")`
	`91`	`+ await router.push("/")`
`92`	`92`	`} catch (err) {`
`93`	`93`	`helpers.setFieldError("password", "The username or password is incorrect.")`
`94`	`94`	`}`