chore: fix minor int coercion codeql vulnerability (#7024)

deansheather · web-flow · commit 63f9ef24808b · 2023-04-05T21:43:24.000Z
diff --git a/cli/agent.go b/cli/agent.go
@@ -336,8 +336,8 @@ func urlPort(u string) (int, error) {
 		return -1, xerrors.Errorf("invalid url %q: %w", u, err)
 	}
 	if parsed.Port() != "" {
-		port, err := strconv.ParseInt(parsed.Port(), 10, 64)
-		if err == nil && port > 0 {
+		port, err := strconv.ParseUint(parsed.Port(), 10, 16)
+		if err == nil && port > 0 && port < 1<<16 {
 			return int(port), nil
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -336,8 +336,8 @@ func urlPort(u string) (int, error) {`
`336`	`336`	`return -1, xerrors.Errorf("invalid url %q: %w", u, err)`
`337`	`337`	`}`
`338`	`338`	`if parsed.Port() != "" {`
`339`		`- port, err := strconv.ParseInt(parsed.Port(), 10, 64)`
`340`		`- if err == nil && port > 0 {`
	`339`	`+ port, err := strconv.ParseUint(parsed.Port(), 10, 16)`
	`340`	`+ if err == nil && port > 0 && port < 1<<16 {`
`341`	`341`	`return int(port), nil`
`342`	`342`	`}`
`343`	`343`	`}`