chore: change argument order

DanielleMaywood · DanielleMaywood · commit 6a288bfeb9b1 · 2025-01-21T10:34:47.000Z
diff --git a/coderd/database/dbgen/dbgen.go b/coderd/database/dbgen/dbgen.go
@@ -211,7 +211,7 @@ func WorkspaceAgentScript(t testing.TB, db database.Store, orig database.Workspa
 	return scripts[0]
 }
 
-func WorkspaceAgentScripts(t testing.TB, db database.Store, orig database.WorkspaceAgentScript, count int) []database.WorkspaceAgentScript {
+func WorkspaceAgentScripts(t testing.TB, db database.Store, count int, orig database.WorkspaceAgentScript) []database.WorkspaceAgentScript {
 	scripts := make([]database.WorkspaceAgentScript, 0, count)
 	for range count {
 		scripts = append(scripts, WorkspaceAgentScript(t, db, orig))
diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go
@@ -1571,7 +1571,7 @@ func TestWorkspaceBuildTimings(t *testing.T) {
 				ScriptID:  script.ID,
 			})
 
-			// Add an hour to the previous started so we can
+			// Add an hour to the previous "started at" so we can
 			// reliably differentiate the scripts from each other.
 			scriptStartedAt = scriptStartedAt.Add(1 * time.Hour)
 		}
@@ -1600,9 +1600,9 @@ func TestWorkspaceBuildTimings(t *testing.T) {
 		agent := dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{
 			ResourceID: resource.ID,
 		})
-		scripts := dbgen.WorkspaceAgentScripts(t, db, database.WorkspaceAgentScript{
+		scripts := dbgen.WorkspaceAgentScripts(t, db, 5, database.WorkspaceAgentScript{
 			WorkspaceAgentID: agent.ID,
-		}, 5)
+		})
 		agentScriptTimings := dbgen.WorkspaceAgentScriptTimings(t, db, scripts)
 
 		// When: fetching timings for the build
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -3913,9 +3913,9 @@ func TestWorkspaceTimings(t *testing.T) {
 		agent := dbgen.WorkspaceAgent(t, db, database.WorkspaceAgent{
 			ResourceID: resource.ID,
 		})
-		scripts := dbgen.WorkspaceAgentScripts(t, db, database.WorkspaceAgentScript{
+		scripts := dbgen.WorkspaceAgentScripts(t, db, 3, database.WorkspaceAgentScript{
 			WorkspaceAgentID: agent.ID,
-		}, 3)
+		})
 		dbgen.WorkspaceAgentScriptTimings(t, db, scripts)
 
 		// When: fetching the timings

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,7 @@ func WorkspaceAgentScript(t testing.TB, db database.Store, orig database.Workspa`
`211`	`211`	`return scripts[0]`
`212`	`212`	`}`
`213`	`213`
`214`		`-func WorkspaceAgentScripts(t testing.TB, db database.Store, orig database.WorkspaceAgentScript, count int) []database.WorkspaceAgentScript {`
	`214`	`+func WorkspaceAgentScripts(t testing.TB, db database.Store, count int, orig database.WorkspaceAgentScript) []database.WorkspaceAgentScript {`
`215`	`215`	`scripts := make([]database.WorkspaceAgentScript, 0, count)`
`216`	`216`	`for range count {`
`217`	`217`	`scripts = append(scripts, WorkspaceAgentScript(t, db, orig))`