Fix tests

BrunoQuaresma · BrunoQuaresma · commit 6c7c8b940af3 · 2022-12-02T13:30:40.000Z
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -1721,35 +1721,40 @@ func (q *fakeQuerier) GetPreviousTemplateVersion(_ context.Context, arg database
 	q.mutex.RLock()
 	defer q.mutex.RUnlock()
 
-	sortedTemplateVersions := slices.Clone(q.templateVersions)
-	slices.SortFunc(sortedTemplateVersions, func(i, j database.TemplateVersion) bool {
-		return i.CreatedAt.After(j.CreatedAt)
-	})
-
-	templateVersions := make([]database.TemplateVersion, 0)
-	for _, templateVersion := range sortedTemplateVersions {
-		if templateVersion.OrganizationID != arg.OrganizationID {
+	var currentTemplateVersion database.TemplateVersion
+	for _, templateVersion := range q.templateVersions {
+		if templateVersion.TemplateID != arg.TemplateID {
 			continue
 		}
-		if templateVersion.TemplateID != arg.TemplateID {
+		if templateVersion.Name != arg.Name {
+			continue
+		}
+		if templateVersion.OrganizationID != arg.OrganizationID {
 			continue
 		}
-		templateVersions = append(templateVersions, templateVersion)
+		currentTemplateVersion = templateVersion
+		break
 	}
 
-	templateVersionIndex := -1
-	for versionIndex, templateVersion := range templateVersions {
-		if strings.EqualFold(templateVersion.Name, arg.Name) {
-			templateVersionIndex = versionIndex
-			break
+	previousTemplateVersions := make([]database.TemplateVersion, 0)
+	for _, templateVersion := range q.templateVersions {
+		if templateVersion.ID == currentTemplateVersion.ID {
+			continue
+		}
+		if templateVersion.CreatedAt.Before(currentTemplateVersion.CreatedAt) {
+			previousTemplateVersions = append(previousTemplateVersions, templateVersion)
 		}
 	}
 
-	if templateVersionIndex > 0 {
-		return templateVersions[templateVersionIndex], nil
+	if len(previousTemplateVersions) == 0 {
+		return database.TemplateVersion{}, sql.ErrNoRows
 	}
 
-	return database.TemplateVersion{}, sql.ErrNoRows
+	sort.Slice(previousTemplateVersions, func(i, j int) bool {
+		return previousTemplateVersions[i].CreatedAt.After(previousTemplateVersions[j].CreatedAt)
+	})
+
+	return previousTemplateVersions[0], nil
 }
 
 func (q *fakeQuerier) GetParameterSchemasByJobID(_ context.Context, jobID uuid.UUID) ([]database.ParameterSchema, error) {
