Skip to content

Commit 6cf89a4

Browse files
committed
Address PR review
1 parent 1b0ed59 commit 6cf89a4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

site/src/components/AuditLogRow/AuditLogDiff.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ const getDiffValue = (value: number | string | boolean) => {
1111
return value.toString()
1212
}
1313

14-
export const AuditDiff: React.FC<{ diff: AuditLog["diff"] }> = ({ diff }) => {
14+
export const AuditLogDiff: React.FC<{ diff: AuditLog["diff"] }> = ({ diff }) => {
1515
const styles = useStyles()
1616
const diffEntries = Object.entries(diff)
1717

site/src/components/AuditLogRow/AuditLogRow.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ import { UserAvatar } from "components/UserAvatar/UserAvatar"
1111
import { ComponentProps, useState } from "react"
1212
import { Link as RouterLink } from "react-router-dom"
1313
import { createDayString } from "util/createDayString"
14-
import { AuditDiff } from "./AuditLogDiff"
14+
import { AuditLogDiff } from "./AuditLogDiff"
1515

1616
const pillTypeByHttpStatus = (httpStatus: number): ComponentProps<typeof Pill>["type"] => {
1717
if (httpStatus >= 300 && httpStatus < 500) {
1818
return "warning"
1919
}
2020

21-
if (httpStatus > 500) {
21+
if (httpStatus >= 500) {
2222
return "error"
2323
}
2424

@@ -171,7 +171,7 @@ export const AuditLogRow: React.FC<AuditLogRowProps> = ({
171171

172172
{shouldDisplayDiff && (
173173
<Collapse in={isDiffOpen}>
174-
<AuditDiff diff={auditLog.diff} />
174+
<AuditLogDiff diff={auditLog.diff} />
175175
</Collapse>
176176
)}
177177
</TableCell>

0 commit comments

Comments
 (0)