Remove unnecessary metric from test

dannykopping · dannykopping · commit 6f9537100d42 · 2024-03-26T14:04:49.000+02:00
Use stronger rand

Signed-off-by: Danny Kopping &lt;danny@coder.com&gt;
diff --git a/cli/server_test.go b/cli/server_test.go
@@ -973,26 +973,20 @@ func TestServer(t *testing.T) {
 
 			scanner := bufio.NewScanner(res.Body)
 			hasActiveUsers := false
-			hasWorkspaces := false
 			for scanner.Scan() {
 				// This metric is manually registered to be tracked in the server. That's
 				// why we test it's tracked here.
 				if strings.HasPrefix(scanner.Text(), "coderd_api_active_users_duration_hour") {
 					hasActiveUsers = true
 					continue
 				}
-				if strings.HasPrefix(scanner.Text(), "coderd_api_workspace_latest_build_total") {
-					hasWorkspaces = true
-					continue
-				}
 				if strings.HasPrefix(scanner.Text(), "coderd_db_query_latencies_seconds") {
 					t.Fatal("db metrics should not be tracked when --prometheus-collect-db-metrics is not enabled")
 				}
 				t.Logf("scanned %s", scanner.Text())
 			}
 			require.NoError(t, scanner.Err())
 			require.True(t, hasActiveUsers)
-			require.True(t, hasWorkspaces)
 		})
 
 		t.Run("DBMetricsEnabled", func(t *testing.T) {
diff --git a/coderd/prometheusmetrics/prometheusmetrics_test.go b/coderd/prometheusmetrics/prometheusmetrics_test.go
@@ -5,7 +5,6 @@ import (
 	"database/sql"
 	"encoding/json"
 	"fmt"
-	"math/rand"
 	"os"
 	"reflect"
 	"sync/atomic"
@@ -669,7 +668,9 @@ func insertUser(t *testing.T, db database.Store) database.User {
 
 func insertRunning(t *testing.T, db database.Store) database.ProvisionerJob {
 	var template, templateVersion uuid.UUID
-	if rand.Intn(10) > 5 {
+	rnd, err := cryptorand.Intn(10)
+	require.NoError(t, err)
+	if rnd > 5 {
 		template = templateB
 		templateVersion = templateVersionB
 	} else {
