fix: clean up TS in ResourceAvatar

jsjoeio · jsjoeio · commit 728ceeb4f9c5 · 2022-08-30T15:42:23.000Z
diff --git a/site/src/components/Resources/ResourceAvatar.tsx b/site/src/components/Resources/ResourceAvatar.tsx
@@ -1,7 +1,6 @@
 import Avatar from "@material-ui/core/Avatar"
 import { makeStyles } from "@material-ui/core/styles"
 import FolderIcon from "@material-ui/icons/FolderOutlined"
-import HelpIcon from "@material-ui/icons/HelpOutlined"
 import WidgetsIcon from "@material-ui/icons/WidgetsOutlined"
 import ImageIcon from "@material-ui/icons/ImageOutlined"
 import MemoryIcon from "@material-ui/icons/MemoryOutlined"
@@ -13,7 +12,9 @@ const AdjustedMemoryIcon: typeof MemoryIcon = ({ style, ...props }) => {
   return <MemoryIcon style={{ ...style, fontSize: 24 }} {...props} />
 }
 
-const iconByResource: Record<string, typeof MemoryIcon> = {
+type ValidIcons = 'docker_volume' | 'docker_container' | 'docker_image' | 'kubernetes_persistent_volume_claim' | 'kubernetes_pod' | 'google_compute_disk' | 'google_compute_instance' | 'aws_instance' | 'kubernetes_deployment' | 'null_resource'
+
+const iconByResource: Record<ValidIcons, typeof MemoryIcon | undefined> = {
   docker_volume: FolderIcon,
   docker_container: AdjustedMemoryIcon,
   docker_image: ImageIcon,
@@ -26,12 +27,10 @@ const iconByResource: Record<string, typeof MemoryIcon> = {
   null_resource: WidgetsIcon,
 }
 
-export type ResourceAvatarProps = { type: string }
+export type ResourceAvatarProps = { type: ValidIcons }
 
 export const ResourceAvatar: React.FC<ResourceAvatarProps> = ({ type }) => {
-  // this resource can return undefined
-  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
-  const IconComponent = iconByResource[type] ?? HelpIcon
+  const IconComponent = iconByResource[type] ?? WidgetsIcon
   const styles = useStyles()
 
   return (
