fix: sort.slice

mtojek · mtojek · commit 767ada889270 · 2024-05-20T15:21:22.000+02:00
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -4189,6 +4189,10 @@ func (q *FakeQuerier) GetTemplateVersionWorkspaceTags(_ context.Context, templat
 		}
 		workspaceTags = append(workspaceTags, workspaceTag)
 	}
+
+	sort.Slice(workspaceTags, func(i, j int) bool {
+		return workspaceTags[i].Key < workspaceTags[j].Key
+	})
 	return workspaceTags, nil
 }
 
diff --git a/provisioner/terraform/parse_test.go b/provisioner/terraform/parse_test.go
@@ -368,12 +368,9 @@ func TestParse(t *testing.T) {
 		{
 			Name: "non-tf-files",
 			Files: map[string]string{
-				"readme.md":    `Hello world`,
 				"any-file.txt": "Foobar",
 			},
-			Response: &proto.ParseComplete{
-				Readme: []byte("Hello world"),
-			},
+			Response: &proto.ParseComplete{},
 		},
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -4189,6 +4189,10 @@ func (q *FakeQuerier) GetTemplateVersionWorkspaceTags(_ context.Context, templat`
`4189`	`4189`	`}`
`4190`	`4190`	`workspaceTags = append(workspaceTags, workspaceTag)`
`4191`	`4191`	`}`
	`4192`	`+`
	`4193`	`+ sort.Slice(workspaceTags, func(i, j int) bool {`
	`4194`	`+ return workspaceTags[i].Key < workspaceTags[j].Key`
	`4195`	`+ })`
`4192`	`4196`	`return workspaceTags, nil`
`4193`	`4197`	`}`
`4194`	`4198`
Original file line number	Diff line number	Diff line change
`@@ -368,12 +368,9 @@ func TestParse(t *testing.T) {`
`368`	`368`	`{`
`369`	`369`	`Name: "non-tf-files",`
`370`	`370`	`Files: map[string]string{`
`371`		- "readme.md": `Hello world`,
`372`	`371`	`"any-file.txt": "Foobar",`
`373`	`372`	`},`
`374`		`- Response: &proto.ParseComplete{`
`375`		`- Readme: []byte("Hello world"),`
`376`		`- },`
	`373`	`+ Response: &proto.ParseComplete{},`
`377`	`374`	`},`
`378`	`375`	`}`
`379`	`376`