Listen to web terminal keydown on capture

code-asher · code-asher · commit 78ec07ba52e8 · 2023-09-14T10:40:24.000-08:00
Instead of bubbling.  I think maybe what happens here is that xterm is
capturing key presses and preventing the event from bubbling?  So
setting the listener on the capture phase instead works around this.
Probably would also work to dipsose the terminal.
diff --git a/site/src/pages/TerminalPage/TerminalPage.tsx b/site/src/pages/TerminalPage/TerminalPage.tsx
@@ -479,10 +479,10 @@ const useReloading = (isDisconnected: boolean) => {
       window.location.reload();
     };
 
-    document.addEventListener("keydown", keyDownHandler);
+    document.addEventListener("keydown", keyDownHandler, true);
 
     return () => {
-      document.removeEventListener("keydown", keyDownHandler);
+      document.removeEventListener("keydown", keyDownHandler, true);
     };
   }, [isDisconnected]);
 
