fix: Line gets erased due to updateJob (#4740)

sonnysasaka · web-flow · commit 7d831e31c623 · 2022-10-25T10:27:44.000-05:00
The first updateJob should be called after the first printStage to guarantee that only stage prints can get erased and overwritten, otherwise there could be an unrelated line that gets erased. fixes #3967
diff --git a/cli/cliui/provisionerjob.go b/cli/cliui/provisionerjob.go
@@ -103,7 +103,6 @@ func ProvisionerJob(ctx context.Context, writer io.Writer, opts ProvisionerJobOp
 		}
 		updateStage("Running", *job.StartedAt)
 	}
-	updateJob()
 
 	if opts.Cancel != nil {
 		// Handles ctrl+c to cancel a job.
@@ -131,6 +130,7 @@ func ProvisionerJob(ctx context.Context, writer io.Writer, opts ProvisionerJobOp
 
 	// The initial stage needs to print after the signal handler has been registered.
 	printStage()
+	updateJob()
 
 	logs, closer, err := opts.Logs()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,6 @@ func ProvisionerJob(ctx context.Context, writer io.Writer, opts ProvisionerJobOp`
`103`	`103`	`}`
`104`	`104`	`updateStage("Running", *job.StartedAt)`
`105`	`105`	`}`
`106`		`- updateJob()`
`107`	`106`
`108`	`107`	`if opts.Cancel != nil {`
`109`	`108`	`// Handles ctrl+c to cancel a job.`
`@@ -131,6 +130,7 @@ func ProvisionerJob(ctx context.Context, writer io.Writer, opts ProvisionerJobOp`
`131`	`130`
`132`	`131`	`// The initial stage needs to print after the signal handler has been registered.`
`133`	`132`	`printStage()`
	`133`	`+ updateJob()`
`134`	`134`
`135`	`135`	`logs, closer, err := opts.Logs()`
`136`	`136`	`if err != nil {`