First round of lint failures

bryphe-coder · bryphe-coder · commit 8343ef030e2e · 2022-01-22T21:50:47.000Z
diff --git a/site/api.ts b/site/api.ts
@@ -83,7 +83,7 @@ export namespace Project {
 
   export const createWorkspace = async (name: string): Promise<string> => {
     await wait(250)
-    return "test-workspace"
+    return name
   }
 }
 
diff --git a/site/components/Form/FormSection.tsx b/site/components/Form/FormSection.tsx
@@ -1,7 +1,5 @@
-import FormHelperText from "@material-ui/core/FormHelperText"
 import { makeStyles } from "@material-ui/core/styles"
 import Typography from "@material-ui/core/Typography"
-import { Style } from "@material-ui/icons"
 import React from "react"
 
 export interface FormSectionProps {
diff --git a/site/components/Form/FormTextField.tsx b/site/components/Form/FormTextField.tsx
@@ -18,21 +18,6 @@ export interface FormFieldProps<T> {
   formFieldName: keyof T
 }
 
-/**
- * FormFieldProps are required props for creating form fields using a factory.
- */
-export interface FormFieldProps<T> {
-  /**
-   * form is a reference to a form or subform and is used to compute common
-   * states such as error and helper text
-   */
-  form: FormikLike<T>
-  /**
-   * formFieldName is a field name associated with the form schema.
-   */
-  formFieldName: keyof T
-}
-
 /**
  * FormTextFieldProps extends form-related MUI TextFieldProps with Formik
  * props. The passed in form is used to compute error states and configure
diff --git a/site/components/Form/index.ts b/site/components/Form/index.ts
@@ -1,4 +1,4 @@
 export * from "./FormRow"
 export * from "./FormSection"
 export * from "./FormTextField"
-export * from "./FormTitle"
+export * from "./FormTitle"
diff --git a/site/components/Navbar/index.tsx b/site/components/Navbar/index.tsx
@@ -1,7 +1,5 @@
 import React from "react"
 import Button from "@material-ui/core/Button"
-import List from "@material-ui/core/List"
-import ListSubheader from "@material-ui/core/ListSubheader"
 import { makeStyles } from "@material-ui/core/styles"
 import Link from "next/link"
 
diff --git a/site/components/PageTemplates/FormPage.tsx b/site/components/PageTemplates/FormPage.tsx
@@ -1,5 +1,4 @@
 import Button from "@material-ui/core/Button"
-import Typography from "@material-ui/core/Typography"
 import { makeStyles } from "@material-ui/core/styles"
 import { ButtonProps } from "@material-ui/core/Button"
 import React from "react"
diff --git a/site/components/PageTemplates/LoadingPage.tsx b/site/components/PageTemplates/LoadingPage.tsx
@@ -1,4 +1,5 @@
-import { Box, CircularProgress, makeStyles } from "@material-ui/core"
+import { makeStyles } from "@material-ui/core/styles"
+import CircularProgress from "@material-ui/core/CircularProgress"
 import React from "react"
 import { RequestState } from "../../hooks/useRequestor"
 
diff --git a/site/components/PageTemplates/RedirectPage.tsx b/site/components/PageTemplates/RedirectPage.tsx
@@ -9,7 +9,8 @@ export const RedirectPage: React.FC<RedirectPageProps> = ({ path }) => {
   const router = useRouter()
 
   useEffect(() => {
-    router.push(path)
+    // 'void' - we're OK with this promise being fire-and-forget
+    void router.push(path)
   })
 
   return null
diff --git a/site/components/Project/ProjectIcon.tsx b/site/components/Project/ProjectIcon.tsx
@@ -1,5 +1,6 @@
 import React from "react"
-import { Box, makeStyles } from "@material-ui/core"
+import { makeStyles } from "@material-ui/core/styles"
+import Box from "@material-ui/core/Box"
 import { ProjectName } from "./ProjectName"
 
 export interface ProjectIconProps {
diff --git a/site/components/Project/ProjectName.tsx b/site/components/Project/ProjectName.tsx
@@ -1,5 +1,6 @@
 import React from "react"
-import { makeStyles, Typography } from "@material-ui/core"
+import { makeStyles } from "@material-ui/core/styles"
+import Typography from "@material-ui/core/Typography"
 
 const useStyles = makeStyles((theme) => ({
   root: {
diff --git a/site/hooks/useRequestor.ts b/site/hooks/useRequestor.ts
@@ -3,18 +3,19 @@ import isReady from "next/router"
 
 export type RequestState<TPayload> =
   | {
-      state: "loading"
-    }
+    state: "loading"
+  }
   | {
-      state: "error"
-      error: Error
-    }
+    state: "error"
+    error: Error
+  }
   | {
-      state: "success"
-      payload: TPayload
-    }
+    state: "success"
+    payload: TPayload
+  }
 
-export const useRequestor = <TPayload>(fn: () => Promise<TPayload>, deps: any[] = []) => {
+// TODO: Replace with `useSWR`
+export const useRequestor = <TPayload>(fn: () => Promise<TPayload>, deps: any[] = []): RequestState<TPayload> => {
   const [requestState, setRequestState] = useState<RequestState<TPayload>>({ state: "loading" })
 
   useEffect(() => {
diff --git a/site/pages/workspaces/index.tsx b/site/pages/workspaces/index.tsx
@@ -1,7 +1,9 @@
 import React from "react"
 import { useRouter } from "next/router"
-import { makeStyles, Box, Paper } from "@material-ui/core"
-import { AddToQueue as AddWorkspaceIcon } from "@material-ui/icons"
+import { makeStyles } from "@material-ui/core/styles"
+import Box from "@material-ui/core/Box"
+import Paper from "@material-ui/core/Paper"
+import AddWorkspaceIcon from "@material-ui/icons/AddToQueue"
 
 import { EmptyState, SplitButton } from "../../components"
 import { AppPage } from "../../components/PageTemplates"

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ export namespace Project {`
`83`	`83`
`84`	`84`	`export const createWorkspace = async (name: string): Promise<string> => {`
`85`	`85`	`await wait(250)`
`86`		`- return "test-workspace"`
	`86`	`+ return name`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import Button from "@material-ui/core/Button"`
`2`		`-import Typography from "@material-ui/core/Typography"`
`3`	`2`	`import { makeStyles } from "@material-ui/core/styles"`
`4`	`3`	`import { ButtonProps } from "@material-ui/core/Button"`
`5`	`4`	`import React from "react"`