fix: use dbtime in dbmem query to fix flake (#16773)

ethanndickson · web-flow · commit 88f0131abbc9 · 2025-03-03T13:42:13.000Z
Closes coder/internal#447. The test was failing 30% of the time on Windows without the rounding applied by `dbtime`. `dbtime` was used on the timestamps inserted into the DB, but not within the query. Once using `dbtime` within the query there were no failures in 200 runs.
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -7014,7 +7014,7 @@ func (q *FakeQuerier) GetWorkspaceAgentUsageStatsAndLabels(_ context.Context, cr
 		}
 		// WHERE usage = true AND created_at > now() - '1 minute'::interval
 		// GROUP BY user_id, agent_id, workspace_id
-		if agentStat.Usage && agentStat.CreatedAt.After(time.Now().Add(-time.Minute)) {
+		if agentStat.Usage && agentStat.CreatedAt.After(dbtime.Now().Add(-time.Minute)) {
 			val, ok := latestAgentStats[key]
 			if !ok {
 				latestAgentStats[key] = agentStat

Original file line number	Diff line number	Diff line change
`@@ -7014,7 +7014,7 @@ func (q *FakeQuerier) GetWorkspaceAgentUsageStatsAndLabels(_ context.Context, cr`
`7014`	`7014`	`}`
`7015`	`7015`	`// WHERE usage = true AND created_at > now() - '1 minute'::interval`
`7016`	`7016`	`// GROUP BY user_id, agent_id, workspace_id`
`7017`		`- if agentStat.Usage && agentStat.CreatedAt.After(time.Now().Add(-time.Minute)) {`
	`7017`	`+ if agentStat.Usage && agentStat.CreatedAt.After(dbtime.Now().Add(-time.Minute)) {`
`7018`	`7018`	`val, ok := latestAgentStats[key]`
`7019`	`7019`	`if !ok {`
`7020`	`7020`	`latestAgentStats[key] = agentStat`