nits

johnstcn · johnstcn · commit 92a4b991c0da · 2025-06-20T13:03:45.000+01:00
diff --git a/coderd/database/dbmem/dbmem.go b/coderd/database/dbmem/dbmem.go
@@ -4464,6 +4464,7 @@ func (q *FakeQuerier) GetProvisionerDaemons(_ context.Context) ([]database.Provi
 	defer q.mutex.RUnlock()
 
 	if len(q.provisionerDaemons) == 0 {
+		// Returning err=nil here for consistency with real querier
 		return []database.ProvisionerDaemon{}, nil
 	}
 	// copy the data so that the caller can't manipulate any data inside dbmem
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -424,10 +424,10 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	var qpr database.GetProvisionerJobsByIDsWithQueuePositionRow
+	var queuePos database.GetProvisionerJobsByIDsWithQueuePositionRow
 	if provisionerJob != nil {
-		qpr.ProvisionerJob = *provisionerJob
-		qpr.QueuePosition = 0
+		queuePos.ProvisionerJob = *provisionerJob
+		queuePos.QueuePosition = 0
 		if err := provisionerjobs.PostJob(api.Pubsub, *provisionerJob); err != nil {
 			// Client probably doesn't care about this error, so just log it.
 			api.Logger.Error(ctx, "failed to post provisioner job to pubsub", slog.Error(err))
@@ -468,7 +468,7 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
 	apiBuild, err := api.convertWorkspaceBuild(
 		*workspaceBuild,
 		workspace,
-		qpr,
+		queuePos,
 		[]database.WorkspaceResource{},
 		[]database.WorkspaceResourceMetadatum{},
 		[]database.WorkspaceAgent{},
diff --git a/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceDeleteDialog.tsx b/site/src/modules/workspaces/WorkspaceMoreActions/WorkspaceDeleteDialog.tsx
@@ -49,7 +49,7 @@ export const WorkspaceDeleteDialog: FC<WorkspaceDeleteDialogProps> = ({
 	//    usually means that builds are failing as well.
 	// b) No provisioner is available to delete the workspace, which will
 	//    cause the job to remain in the "pending" state indefinitely.
-	//    The assumption here is that and admin will cancel the job.
+	//    The assumption here is that an admin will cancel the job.
 	const canOrphan =
 		canDeleteFailedWorkspace &&
 		(workspace.latest_build.status === "failed" ||

Original file line number	Diff line number	Diff line change
`@@ -4464,6 +4464,7 @@ func (q *FakeQuerier) GetProvisionerDaemons(_ context.Context) ([]database.Provi`
`4464`	`4464`	`defer q.mutex.RUnlock()`
`4465`	`4465`
`4466`	`4466`	`if len(q.provisionerDaemons) == 0 {`
	`4467`	`+ // Returning err=nil here for consistency with real querier`
`4467`	`4468`	`return []database.ProvisionerDaemon{}, nil`
`4468`	`4469`	`}`
`4469`	`4470`	`// copy the data so that the caller can't manipulate any data inside dbmem`