fix: panic

mtojek · mtojek · commit 92c999200711 · 2024-05-22T15:11:04.000+02:00
diff --git a/coderd/wsbuilder/wsbuilder.go b/coderd/wsbuilder/wsbuilder.go
@@ -675,7 +675,7 @@ func (b *Builder) getProvisionerTags() (map[string]string, error) {
 
 	evalCtx := buildParametersEvalContext(parameterNames, parameterValues)
 	for _, workspaceTag := range workspaceTags {
-		expr, diags := hclsyntax.ParseExpression([]byte(workspaceTag.Value), "partial.hcl", hcl.InitialPos)
+		expr, diags := hclsyntax.ParseExpression([]byte(workspaceTag.Value), "expression.hcl", hcl.InitialPos)
 		if diags.HasErrors() {
 			return nil, BuildError{http.StatusBadRequest, "failed to parse workspace tag value", xerrors.Errorf(diags.Error())}
 		}
@@ -702,6 +702,11 @@ func buildParametersEvalContext(names, values []string) *hcl.EvalContext {
 			"value": cty.StringVal(values[i]),
 		})
 	}
+
+	if len(m) == 0 {
+		return nil // otherwise, panic: must not call MapVal with empty map
+	}
+
 	return &hcl.EvalContext{
 		Variables: map[string]cty.Value{
 			"data": cty.MapVal(map[string]cty.Value{
