chore: suggestions

DanielleMaywood · DanielleMaywood · commit 93bf7b7fb38c · 2025-04-03T09:40:38.000+01:00
- Invert an if-condition to reduce how nested the code was.
- Hide `-c` flag for now
diff --git a/cli/open.go b/cli/open.go
@@ -123,23 +123,25 @@ func (r *RootCmd) openVSCode() *serpent.Command {
 				var foundContainer bool
 
 				for _, container := range containers.Containers {
-					if container.FriendlyName == containerName {
-						foundContainer = true
-
-						if directory == "" {
-							localFolder, ok := container.Labels["devcontainer.local_folder"]
-							if !ok {
-								return xerrors.New("container missing `devcontainer.local_folder` label")
-							}
-
-							directory, ok = container.Volumes[localFolder]
-							if !ok {
-								return xerrors.New("container missing volume for `devcontainer.local_folder`")
-							}
+					if container.FriendlyName != containerName {
+						continue
+					}
+
+					foundContainer = true
+
+					if directory == "" {
+						localFolder, ok := container.Labels["devcontainer.local_folder"]
+						if !ok {
+							return xerrors.New("container missing `devcontainer.local_folder` label")
 						}
 
-						break
+						directory, ok = container.Volumes[localFolder]
+						if !ok {
+							return xerrors.New("container missing volume for `devcontainer.local_folder`")
+						}
 					}
+
+					break
 				}
 
 				if !foundContainer {
@@ -250,6 +252,7 @@ func (r *RootCmd) openVSCode() *serpent.Command {
 			FlagShorthand: "c",
 			Description:   "Container name to connect to in the workspace.",
 			Value:         serpent.StringOf(&containerName),
+			Hidden:        true, // Hidden until this features is at least in beta.
 		},
 		{
 			Flag:        "test.open-error",
diff --git a/cli/testdata/coder_open_vscode_--help.golden b/cli/testdata/coder_open_vscode_--help.golden
@@ -6,9 +6,6 @@ USAGE:
   Open a workspace in VS Code Desktop
 
 OPTIONS:
-  -c, --container string
-          Container name to connect to in the workspace.
-
       --generate-token bool, $CODER_OPEN_VSCODE_GENERATE_TOKEN
           Generate an auth token and include it in the vscode:// URI. This is
           for automagical configuration of VS Code Desktop and not needed if
diff --git a/docs/reference/cli/open_vscode.md b/docs/reference/cli/open_vscode.md
