fix(coderd): prevent agent reverse proxy from using HTTP[S]_PROXY envs

coadler · coadler · commit 95fab6b2d458 · 2024-04-04T23:20:13.000Z
diff --git a/coderd/tailnet.go b/coderd/tailnet.go
@@ -37,6 +37,9 @@ func init() {
 	if !valid {
 		panic("dev error: default transport is the wrong type")
 	}
+	// We do not want to respect the proxy settings from the environment, since
+	// all network traffic happens over wireguard.
+	tailnetTransport.Proxy = nil
 }
 
 var _ workspaceapps.AgentProvider = (*ServerTailnet)(nil)

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ func init() {`
`37`	`37`	`if !valid {`
`38`	`38`	`panic("dev error: default transport is the wrong type")`
`39`	`39`	`}`
	`40`	`+ // We do not want to respect the proxy settings from the environment, since`
	`41`	`+ // all network traffic happens over wireguard.`
	`42`	`+ tailnetTransport.Proxy = nil`
`40`	`43`	`}`
`41`	`44`
`42`	`45`	`var _ workspaceapps.AgentProvider = (*ServerTailnet)(nil)`