workspace build error

mtojek · mtojek · commit 97ddf3a53f05 · 2023-06-22T13:25:57.000+02:00
diff --git a/coderd/autobuild/lifecycle_executor.go b/coderd/autobuild/lifecycle_executor.go
@@ -166,7 +166,7 @@ func (e *Executor) runOnce(t time.Time) Stats {
 					Reason(reason)
 
 				if _, _, err := builder.Build(e.ctx, tx, nil); err != nil {
-					log.Error(e.ctx, "unable to transition workspace",
+					log.Error(e.ctx, "workspace build error",
 						slog.F("transition", nextTransition),
 						slog.Error(err),
 					)
diff --git a/coderd/workspacebuilds.go b/coderd/workspacebuilds.go
@@ -14,6 +14,8 @@ import (
 	"golang.org/x/exp/slices"
 	"golang.org/x/xerrors"
 
+	"cdr.dev/slog"
+
 	"github.com/coder/coder/coderd/database"
 	"github.com/coder/coder/coderd/database/db2sdk"
 	"github.com/coder/coder/coderd/database/dbauthz"
@@ -348,6 +350,10 @@ func (api *API) postWorkspaceBuilds(rw http.ResponseWriter, r *http.Request) {
 	)
 	var buildErr wsbuilder.BuildError
 	if xerrors.As(err, &buildErr) {
+		if buildErr.Status == http.StatusInternalServerError {
+			api.Logger.Error(ctx, "workspace build error", slog.Error(buildErr.Wrapped))
+		}
+
 		httpapi.Write(ctx, rw, buildErr.Status, codersdk.Response{
 			Message: buildErr.Message,
 			Detail:  buildErr.Error(),
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
@@ -454,6 +454,10 @@ func (api *API) postWorkspacesByOrganization(rw http.ResponseWriter, r *http.Req
 	}, nil)
 	var bldErr wsbuilder.BuildError
 	if xerrors.As(err, &bldErr) {
+		if bldErr.Status == http.StatusInternalServerError {
+			api.Logger.Error(ctx, "workspace build error", slog.Error(bldErr.Wrapped))
+		}
+
 		httpapi.Write(ctx, rw, bldErr.Status, codersdk.Response{
 			Message: bldErr.Message,
 			Detail:  bldErr.Error(),

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ func (e *Executor) runOnce(t time.Time) Stats {`
`166`	`166`	`Reason(reason)`
`167`	`167`
`168`	`168`	`if _, _, err := builder.Build(e.ctx, tx, nil); err != nil {`
`169`		`- log.Error(e.ctx, "unable to transition workspace",`
	`169`	`+ log.Error(e.ctx, "workspace build error",`
`170`	`170`	`slog.F("transition", nextTransition),`
`171`	`171`	`slog.Error(err),`
`172`	`172`	`)`