test: Return early and avoid using nil handler (#7411)

Emyrk · web-flow · commit 9908c84b2af2 · 2023-05-04T11:14:53.000-05:00
* test: Return early and avoid using nil handler
diff --git a/enterprise/coderd/coderdenttest/proxytest.go b/enterprise/coderd/coderdenttest/proxytest.go
@@ -47,14 +47,17 @@ func NewWorkspaceProxy(t *testing.T, coderdAPI *coderd.API, owner *codersdk.Clie
 		options = &ProxyOptions{}
 	}
 
-	// HTTP Server
+	// HTTP Server. We have to start this once to get the access URL to start
+	// the workspace proxy with. The workspace proxy has the handler, so the
+	// http server will start with a 503 until the proxy is started.
 	var mutex sync.RWMutex
 	var handler http.Handler
 	srv := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		mutex.RLock()
 		defer mutex.RUnlock()
 		if handler == nil {
 			http.Error(w, "handler not set", http.StatusServiceUnavailable)
+			return
 		}
 
 		handler.ServeHTTP(w, r)
