Improve PostgreSQL test speeds

kylecarbs · kylecarbs · commit 99e73d8745bb · 2022-03-22T20:54:07.000Z
diff --git a/.github/workflows/coder.yaml b/.github/workflows/coder.yaml
@@ -135,7 +135,8 @@ jobs:
         with:
           go-version: "^1.17"
 
-      - id: go-cache-paths
+      - name: Echo Go Cache Paths
+        id: go-cache-paths
         run: |
           echo "::set-output name=go-build::$(go env GOCACHE)"
           echo "::set-output name=go-mod::$(go env GOMODCACHE)"
@@ -184,6 +185,23 @@ jobs:
           GIT_COMMIT_MESSAGE: ${{ github.event.head_commit.message }}
         run: go run scripts/datadog-cireport/main.go gotests.xml
 
+      - name: Start PostgreSQL Database
+        if: runner.os == 'Linux'
+        env:
+          POSTGRES_PASSWORD: postgres
+          POSTGRES_USER: postgres
+          POSTGRES_DB: postgres
+          PGDATA: /tmp
+        run: |
+          docker run \
+            -e POSTGRES_PASSWORD=postgres \
+            -e POSTGRES_USER=postgres \
+            -e POSTGRES_DB=postgres \
+            -e PGDATA=/tmp \
+            -p 5432:5432 \
+            -d postgres:11 
+          pg_isready -h 127.0.0.1
+
       - name: Test with PostgreSQL Database
         if: runner.os == 'Linux'
         run: DB=true gotestsum --junitfile="gotests.xml" --packages="./..." --
@@ -350,7 +368,8 @@ jobs:
         with:
           install-only: true
 
-      - id: go-cache-paths
+      - name: Echo Go Cache Paths
+        id: go-cache-paths
         run: |
           echo "::set-output name=go-build::$(go env GOCACHE)"
           echo "::set-output name=go-mod::$(go env GOMODCACHE)"
diff --git a/database/postgres/postgres.go b/database/postgres/postgres.go
@@ -9,6 +9,7 @@ import (
 	"sync"
 	"time"
 
+	"github.com/coder/coder/cryptorand"
 	"github.com/ory/dockertest/v3"
 	"github.com/ory/dockertest/v3/docker"
 	"golang.org/x/xerrors"
@@ -20,6 +21,28 @@ var openPortMutex sync.Mutex
 
 // Open creates a new PostgreSQL server using a Docker container.
 func Open() (string, func(), error) {
+	if os.Getenv("CI") != "" {
+		// In CI, creating a Docker container for each test is slow.
+		// This expects a PostgreSQL instance with the hardcoded credentials
+		// available.
+		dbURL := "postgres://postgres:postgres@127.0.0.1:5432/postgres?sslmode=disable"
+		db, err := sql.Open("postgres", dbURL)
+		if err != nil {
+			return "", nil, xerrors.Errorf("connect to ci postgres: %w", err)
+		}
+		defer db.Close()
+		dbName, err := cryptorand.StringCharset(cryptorand.Lower, 10)
+		if err != nil {
+			return "", nil, xerrors.Errorf("generate db name: %w", err)
+		}
+		dbName = "ci" + dbName
+		_, err = db.Exec("CREATE DATABASE " + dbName)
+		if err != nil {
+			return "", nil, xerrors.Errorf("create db: %w", err)
+		}
+		return "postgres://postgres:postgres@127.0.0.1:5432/" + dbName + "?sslmode=disable", func() {}, nil
+	}
+
 	pool, err := dockertest.NewPool("")
 	if err != nil {
 		return "", nil, xerrors.Errorf("create pool: %w", err)
