fix(coderd/database): migrate workspaces.last_used_at to timestamptz (#9699)

johnstcn · web-flow · commit 9bcff30dee41 · 2023-09-18T11:07:54.000+01:00
diff --git a/coderd/database/dump.sql b/coderd/database/dump.sql
diff --git a/coderd/database/migrations/000155_workspaces_last_used_at_timestamptz.down.sql b/coderd/database/migrations/000155_workspaces_last_used_at_timestamptz.down.sql
@@ -0,0 +1,6 @@
+ALTER TABLE ONLY workspaces
+ALTER COLUMN last_used_at
+	SET DATA TYPE timestamp
+	USING last_used_at::timestamptz AT TIME ZONE 'UTC',
+ALTER COLUMN last_used_at
+	SET DEFAULT '0001-01-01 00:00:00'::timestamp;
diff --git a/coderd/database/migrations/000155_workspaces_last_used_at_timestamptz.up.sql b/coderd/database/migrations/000155_workspaces_last_used_at_timestamptz.up.sql
@@ -0,0 +1,6 @@
+ALTER TABLE ONLY workspaces
+ALTER COLUMN last_used_at
+	SET DATA TYPE timestamptz
+	USING last_used_at::timestamp AT TIME ZONE 'UTC',
+ALTER COLUMN last_used_at
+	SET DEFAULT '0001-01-01 00:00:00+00:00'::timestamptz;
diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go
@@ -1515,12 +1515,8 @@ func TestWorkspaceFilterManual(t *testing.T) {
 	t.Run("LastUsed", func(t *testing.T) {
 		t.Parallel()
 
-		// nolint:gocritic // https://github.com/coder/coder/issues/9682
-		db, ps := dbtestutil.NewDB(t, dbtestutil.WithTimezone("UTC"))
 		client, _, api := coderdtest.NewWithAPI(t, &coderdtest.Options{
 			IncludeProvisionerDaemon: true,
-			Database:                 db,
-			Pubsub:                   ps,
 		})
 		user := coderdtest.CreateFirstUser(t, client)
 		authToken := uuid.NewString()
diff --git a/enterprise/coderd/templates_test.go b/enterprise/coderd/templates_test.go
@@ -13,7 +13,6 @@ import (
 	"github.com/coder/coder/v2/coderd/audit"
 	"github.com/coder/coder/v2/coderd/coderdtest"
 	"github.com/coder/coder/v2/coderd/database"
-	"github.com/coder/coder/v2/coderd/database/dbtestutil"
 	"github.com/coder/coder/v2/coderd/rbac"
 	"github.com/coder/coder/v2/codersdk"
 	"github.com/coder/coder/v2/cryptorand"
@@ -369,14 +368,10 @@ func TestTemplates(t *testing.T) {
 	t.Run("UpdateLastUsedAt", func(t *testing.T) {
 		t.Parallel()
 
-		// nolint:gocritic // https://github.com/coder/coder/issues/9682
-		db, ps := dbtestutil.NewDB(t, dbtestutil.WithTimezone("UTC"))
 		ctx := testutil.Context(t, testutil.WaitMedium)
 		client, user := coderdenttest.New(t, &coderdenttest.Options{
 			Options: &coderdtest.Options{
 				IncludeProvisionerDaemon: true,
-				Database:                 db,
-				Pubsub:                   ps,
 			},
 			LicenseOptions: &coderdenttest.LicenseOptions{
 				Features: license.Features{
