remove unused mutation

Emyrk · Emyrk · commit 9c386a67d5b7 · 2024-12-17T15:09:04.000-06:00
diff --git a/scripts/apitypings/main.go b/scripts/apitypings/main.go
@@ -6,7 +6,6 @@ import (
 
 	"github.com/coder/guts"
 	"github.com/coder/guts/bindings"
-	"github.com/coder/guts/bindings/walk"
 	"github.com/coder/guts/config"
 )
 
@@ -77,7 +76,6 @@ func TsMutations(ts *guts.Typescript) {
 		// Omitempty + null is just '?' in golang json marshal
 		// number?: number | null --> number?: number
 		config.SimplifyOmitEmpty,
-		SimplifyUndefinedUnionFields,
 	)
 }
 
@@ -149,32 +147,3 @@ func FixSerpentStruct(gen *guts.Typescript) {
 		}
 	})
 }
-
-// SimplifyUndefinedUnionFields converts 'foo: string | undefined' to 'foo?: string'
-func SimplifyUndefinedUnionFields(gen *guts.Typescript) {
-	gen.ForEach(func(key string, originalNode bindings.Node) {
-		walk.Walk(questionTokenWalker{}, originalNode)
-	})
-}
-
-type questionTokenWalker struct {
-}
-
-func (q questionTokenWalker) Visit(node bindings.Node) (w walk.Visitor) {
-	switch n := node.(type) {
-	case *bindings.PropertySignature:
-		isUnion, ok := n.Type.(*bindings.UnionType)
-		if !ok {
-			return q
-		}
-		for i, t := range isUnion.Types {
-			if keyword, ok := t.(*bindings.LiteralKeyword); ok && *keyword == bindings.KeywordUndefined {
-				n.QuestionToken = true
-				// Remove undefined
-				isUnion.Types = append(isUnion.Types[:i], isUnion.Types[i+1:]...)
-				break
-			}
-		}
-	}
-	return q
-}
