Skip to content

Commit 9cd4e73

Browse files
committed
more tests
1 parent 44297c6 commit 9cd4e73

File tree

3 files changed

+38
-10
lines changed

3 files changed

+38
-10
lines changed

site/src/components/TemplateVersionWarnings/TemplateVersionWarnings.tsx

+12-10
Original file line numberDiff line numberDiff line change
@@ -17,16 +17,18 @@ export const TemplateVersionWarnings: FC<
1717

1818
return (
1919
<Maybe condition={Boolean(warnings.includes("DEPRECATED_PARAMETERS"))}>
20-
<AlertBanner severity="warning">
21-
<div>
22-
This template uses legacy parameters which will be deprecated in the
23-
next Coder release. Learn how to migrate in{" "}
24-
<Link href="https://coder.com/docs/v2/latest/templates/parameters#migration">
25-
our documentation
26-
</Link>
27-
.
28-
</div>
29-
</AlertBanner>
20+
<div data-testid="warning-deprecated-parameters">
21+
<AlertBanner severity="warning">
22+
<div>
23+
This template uses legacy parameters which will be deprecated in the
24+
next Coder release. Learn how to migrate in{" "}
25+
<Link href="https://coder.com/docs/v2/latest/templates/parameters#migration">
26+
our documentation
27+
</Link>
28+
.
29+
</div>
30+
</AlertBanner>
31+
</div>
3032
</Maybe>
3133
)
3234
}

site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPage.test.tsx

+14
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import {
66
MockTemplate,
77
MockTemplateVersion,
88
MockMemberPermissions,
9+
MockTemplateVersion3,
910
} from "testHelpers/entities"
1011
import { renderWithAuth } from "testHelpers/renderHelpers"
1112
import { server } from "testHelpers/server"
@@ -50,4 +51,17 @@ describe("TemplateSummaryPage", () => {
5051
const dropdownButton = screen.queryByLabelText("open-dropdown")
5152
expect(dropdownButton).toBe(null)
5253
})
54+
it("shows the template version warning", async () => {
55+
server.use(
56+
rest.get(
57+
"/api/v2/templateversions/:templateVersionId",
58+
async (req, res, ctx) => {
59+
return res(ctx.status(200), ctx.json(MockTemplateVersion3))
60+
},
61+
),
62+
)
63+
renderPage()
64+
await screen.findByText(MockTemplate.display_name)
65+
await screen.findByTestId("warning-deprecated-parameters")
66+
})
5367
})

site/src/testHelpers/entities.ts

+12
Original file line numberDiff line numberDiff line change
@@ -312,6 +312,18 @@ You can add instructions here
312312
created_by: MockUser,
313313
}
314314

315+
export const MockTemplateVersion3: TypesGen.TemplateVersion = {
316+
id: "test-template-version-3",
317+
created_at: "2022-05-17T17:39:01.382927298Z",
318+
updated_at: "2022-05-17T17:39:01.382927298Z",
319+
template_id: "test-template",
320+
job: MockProvisionerJob,
321+
name: "test-version-3",
322+
readme: "README",
323+
created_by: MockUser,
324+
warnings: ["DEPRECATED_PARAMETERS"],
325+
}
326+
315327
export const MockTemplate: TypesGen.Template = {
316328
id: "test-template",
317329
created_at: "2022-05-17T17:39:01.382927298Z",

0 commit comments

Comments
 (0)