fix!(helm): remove prometheus-http port declaration from coderd service spec

johnstcn · johnstcn · commit ac6e439e7f45 · 2024-02-19T17:27:37.000Z
diff --git a/helm/coder/templates/service.yaml b/helm/coder/templates/service.yaml
@@ -28,25 +28,6 @@ spec:
       nodePort: {{ .Values.coder.service.httpsNodePort }}
       {{ end }}
     {{- end }}
-    {{- range .Values.coder.env }}
-    {{- if eq .name "CODER_PROMETHEUS_ENABLE" }}
-    {{/*
-      This sadly has to be nested to avoid evaluating the second part
-      of the condition too early and potentially getting type errors if
-      the value is not a string (like a `valueFrom`). We do not support
-      `valueFrom` for this env var specifically.
-      */}}
-    {{- if eq .value "true" }}
-    - name: "prometheus-http"
-      port: 2112
-      targetPort: "prometheus-http"
-      protocol: TCP
-      {{ if eq $.Values.coder.service.type "NodePort" }}
-      nodePort: {{ $.Values.coder.service.prometheusNodePort }}
-      {{ end }}
-    {{- end }}
-    {{- end }}
-    {{- end }}
   {{- if eq "LoadBalancer" .Values.coder.service.type }}
   {{- with .Values.coder.service.loadBalancerIP }}
   loadBalancerIP: {{ . | quote }}
diff --git a/helm/coder/tests/testdata/prometheus.golden b/helm/coder/tests/testdata/prometheus.golden
@@ -93,14 +93,6 @@ spec:
       
       nodePort: 
       
-    
-    - name: "prometheus-http"
-      port: 2112
-      targetPort: "prometheus-http"
-      protocol: TCP
-      
-      nodePort: 31112
-      
   selector:
     app.kubernetes.io/name: coder
     app.kubernetes.io/instance: release-name
