add tests

Emyrk · Emyrk · commit ae75e5dcb37f · 2024-08-22T17:20:47.000-05:00
diff --git a/coderd/util/slice/slice.go b/coderd/util/slice/slice.go
@@ -132,7 +132,7 @@ func Difference[T comparable](a []T, b []T) []T {
 }
 
 func SymmetricDifferenceFunc[T any](a, b []T, equal func(a, b T) bool) (add []T, remove []T) {
-	return DifferenceFunc(a, b, equal), DifferenceFunc(b, a, equal)
+	return DifferenceFunc(b, a, equal), DifferenceFunc(a, b, equal)
 }
 
 func DifferenceFunc[T any](a []T, b []T, equal func(a, b T) bool) []T {
diff --git a/coderd/util/slice/slice_test.go b/coderd/util/slice/slice_test.go
@@ -186,4 +186,48 @@ func TestSymmetricDifference(t *testing.T) {
 		require.ElementsMatch(t, []int{}, add)
 		require.ElementsMatch(t, []int{}, remove)
 	})
+
+	t.Run("ToEmpty", func(t *testing.T) {
+		t.Parallel()
+
+		add, remove := slice.SymmetricDifference(
+			[]int{1, 2, 3},
+			[]int{},
+		)
+		require.ElementsMatch(t, []int{}, add)
+		require.ElementsMatch(t, []int{1, 2, 3}, remove)
+	})
+
+	t.Run("ToNil", func(t *testing.T) {
+		t.Parallel()
+
+		add, remove := slice.SymmetricDifference(
+			[]int{1, 2, 3},
+			nil,
+		)
+		require.ElementsMatch(t, []int{}, add)
+		require.ElementsMatch(t, []int{1, 2, 3}, remove)
+	})
+
+	t.Run("FromEmpty", func(t *testing.T) {
+		t.Parallel()
+
+		add, remove := slice.SymmetricDifference(
+			[]int{},
+			[]int{1, 2, 3},
+		)
+		require.ElementsMatch(t, []int{1, 2, 3}, add)
+		require.ElementsMatch(t, []int{}, remove)
+	})
+
+	t.Run("FromNil", func(t *testing.T) {
+		t.Parallel()
+
+		add, remove := slice.SymmetricDifference(
+			nil,
+			[]int{1, 2, 3},
+		)
+		require.ElementsMatch(t, []int{1, 2, 3}, add)
+		require.ElementsMatch(t, []int{}, remove)
+	})
 }

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ func Difference[T comparable](a []T, b []T) []T {`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`func SymmetricDifferenceFunc[T any](a, b []T, equal func(a, b T) bool) (add []T, remove []T) {`
`135`		`- return DifferenceFunc(a, b, equal), DifferenceFunc(b, a, equal)`
	`135`	`+ return DifferenceFunc(b, a, equal), DifferenceFunc(a, b, equal)`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`func DifferenceFunc[T any](a []T, b []T, equal func(a, b T) bool) []T {`