fix: exclude prebuilt workspaces from template-level lifecycle updates

ssncferreira · ssncferreira · commit b08282ab884d · 2025-08-08T18:14:14.000Z
diff --git a/coderd/database/queries.sql.go b/coderd/database/queries.sql.go
diff --git a/coderd/database/queries/workspaces.sql b/coderd/database/queries/workspaces.sql
@@ -554,11 +554,15 @@ WHERE
 
 -- name: UpdateWorkspacesTTLByTemplateID :exec
 UPDATE
-		workspaces
+	workspaces
 SET
-		ttl = $2
+	ttl = $2
 WHERE
-		template_id = $1;
+	template_id = $1
+	-- Prebuilt workspaces (identified by having the prebuilds system user as owner_id)
+	-- should not have their TTL updated, as they are handled by the prebuilds
+	-- reconciliation loop.
+	AND workspaces.owner_id != 'c42fdf75-3097-471c-8c33-fb52454d81c0'::UUID;
 
 -- name: UpdateWorkspaceLastUsedAt :exec
 UPDATE
@@ -805,8 +809,11 @@ SET
     dormant_at = CASE WHEN @dormant_at::timestamptz > '0001-01-01 00:00:00+00'::timestamptz THEN @dormant_at::timestamptz ELSE dormant_at END
 WHERE
     template_id = @template_id
-AND
-    dormant_at IS NOT NULL
+	AND dormant_at IS NOT NULL
+	-- Prebuilt workspaces (identified by having the prebuilds system user as owner_id)
+	-- should not have their dormant or deleting at set, as these are handled by the
+    -- prebuilds reconciliation loop.
+	AND workspaces.owner_id != 'c42fdf75-3097-471c-8c33-fb52454d81c0'::UUID
 RETURNING *;
 
 -- name: UpdateTemplateWorkspacesLastUsedAt :exec
diff --git a/enterprise/coderd/schedule/template.go b/enterprise/coderd/schedule/template.go
@@ -243,6 +243,10 @@ func (s *EnterpriseTemplateScheduleStore) Set(ctx context.Context, db database.S
 		nextStartAts := []time.Time{}
 
 		for _, workspace := range workspaces {
+			// Skip prebuilt workspaces
+			if workspace.IsPrebuild() {
+				continue
+			}
 			nextStartAt := time.Time{}
 			if workspace.AutostartSchedule.Valid {
 				next, err := agpl.NextAllowedAutostart(s.now(), workspace.AutostartSchedule.String, templateSchedule)
@@ -255,7 +259,7 @@ func (s *EnterpriseTemplateScheduleStore) Set(ctx context.Context, db database.S
 			nextStartAts = append(nextStartAts, nextStartAt)
 		}
 
-		//nolint:gocritic // We need to be able to update information about all workspaces.
+		//nolint:gocritic // We need to be able to update information about regular user workspaces.
 		if err := db.BatchUpdateWorkspaceNextStartAt(dbauthz.AsSystemRestricted(ctx), database.BatchUpdateWorkspaceNextStartAtParams{
 			IDs:          workspaceIDs,
 			NextStartAts: nextStartAts,
@@ -335,6 +339,11 @@ func (s *EnterpriseTemplateScheduleStore) updateWorkspaceBuild(ctx context.Conte
 		return xerrors.Errorf("get workspace %q: %w", build.WorkspaceID, err)
 	}
 
+	// Skip lifecycle updates for prebuilt workspaces
+	if workspace.IsPrebuild() {
+		return nil
+	}
+
 	job, err := db.GetProvisionerJobByID(ctx, build.JobID)
 	if err != nil {
 		return xerrors.Errorf("get provisioner job %q: %w", build.JobID, err)
