fix: fix deadlock of mappingQuery on context canceled

spikecurtis · web-flow · commit b34ecf1e9e3f · 2023-12-07T17:19:18.000+04:00
Fixes #11078 replace bare channel send with SendCtx so that we properly shut down when context is canceled.
diff --git a/enterprise/tailnet/pgcoord.go b/enterprise/tailnet/pgcoord.go
@@ -941,8 +941,7 @@ func (q *querier) mappingQuery(peer mKey) error {
 		return nil
 	}
 	logger.Debug(q.ctx, "sending mappings", slog.F("mapping_len", len(mappings)))
-	mpr.mappings <- mappings
-	return nil
+	return agpl.SendCtx(q.ctx, mpr.mappings, mappings)
 }
 
 func (q *querier) bindingsToMappings(bindings []database.GetTailnetTunnelPeerBindingsRow) ([]mapping, error) {

Original file line number	Diff line number	Diff line change
`@@ -941,8 +941,7 @@ func (q *querier) mappingQuery(peer mKey) error {`
`941`	`941`	`return nil`
`942`	`942`	`}`
`943`	`943`	`logger.Debug(q.ctx, "sending mappings", slog.F("mapping_len", len(mappings)))`
`944`		`- mpr.mappings <- mappings`
`945`		`- return nil`
	`944`	`+ return agpl.SendCtx(q.ctx, mpr.mappings, mappings)`
`946`	`945`	`}`
`947`	`946`
`948`	`947`	`func (q *querier) bindingsToMappings(bindings []database.GetTailnetTunnelPeerBindingsRow) ([]mapping, error) {`