Skip to content

test flake: enterprise/tailnet: goroutine leakl: mappingQuery #11078

@johnstcn

Description

@johnstcn

Seen here: https://github.com/coder/coder/actions/runs/7127968542/job/19409011976

=== Failed
=== FAIL: enterprise/tailnet  (0.00s)
PASS
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 348 in state chan send, with github.com/coder/coder/v2/enterprise/tailnet.(*querier).mappingQuery on top of the stack:
goroutine 348 [chan send]:
github.com/coder/coder/v2/enterprise/tailnet.(*querier).mappingQuery(0xc000576fc0, {0xd9, 0xfe, 0x51, 0x9f, 0xf9, 0x9d, 0x45, 0x44, 0x8a, ...})
	/home/runner/actions-runner/_work/coder/coder/enterprise/tailnet/pgcoord.go:944 +0x805
github.com/coder/coder/v2/enterprise/tailnet.(*querier).query(0xc000f15da0?, {{0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...}, ...})
	/home/runner/actions-runner/_work/coder/coder/enterprise/tailnet/pgcoord.go:892 +0x6c
github.com/coder/coder/v2/enterprise/tailnet.(*querier).worker.func1()
	/home/runner/actions-runner/_work/coder/coder/enterprise/tailnet/pgcoord.go:881 +0x2e
github.com/cenkalti/backoff/v4.RetryNotifyWithTimer.func1()
	/home/runner/go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.1/retry.go:18 +0x1b
github.com/cenkalti/backoff/v4.doRetryNotify[...](0xc000e63ed8?, {0x7f7c589ecfc8, 0xc000a42120}, 0x0, {0x0, 0x0?})
	/home/runner/go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.1/retry.go:88 +0x152
github.com/cenkalti/backoff/v4.RetryNotifyWithTimer(0x0?, {0x7f7c589ecfc8?, 0xc000a42120?}, 0x12952a2e634bfc8a?, {0x0?, 0x0?})
	/home/runner/go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.1/retry.go:61 +0x65
github.com/cenkalti/backoff/v4.RetryNotify(...)
	/home/runner/go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.1/retry.go:49
github.com/cenkalti/backoff/v4.Retry(...)
	/home/runner/go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.1/retry.go:38
github.com/coder/coder/v2/enterprise/tailnet.(*querier).worker(0xc000576fc0)
	/home/runner/actions-runner/_work/coder/coder/enterprise/tailnet/pgcoord.go:880 +0x1f0
created by github.com/coder/coder/v2/enterprise/tailnet.newQuerier.func1
	/home/runner/actions-runner/_work/coder/coder/enterprise/tailnet/pgcoord.go:797 +0x7f
]
FAIL	github.com/coder/coder/v2/enterprise/tailnet	13.102s

It looks like worker() may need to have a lifecycle context plumbed through so it can shut down properly when the coordinator is closed.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions