Address PR comments

mtojek · mtojek · commit b50d2fe74f6d · 2022-11-07T13:00:56.000+01:00
diff --git a/cli/ssh.go b/cli/ssh.go
@@ -74,8 +74,8 @@ func ssh() *cobra.Command {
 			}
 
 			updateWorkspaceBanner, outdated := verifyWorkspaceOutdated(client, workspace)
-			if outdated {
-				_, _ = fmt.Fprintln(cmd.OutOrStdout(), updateWorkspaceBanner)
+			if outdated && isTTYOut(cmd) {
+				_, _ = fmt.Fprintln(cmd.ErrOrStderr(), updateWorkspaceBanner)
 			}
 
 			// OpenSSH passes stderr directly to the calling TTY.

Original file line number	Diff line number	Diff line change
`@@ -74,8 +74,8 @@ func ssh() *cobra.Command {`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`updateWorkspaceBanner, outdated := verifyWorkspaceOutdated(client, workspace)`
`77`		`- if outdated {`
`78`		`- _, _ = fmt.Fprintln(cmd.OutOrStdout(), updateWorkspaceBanner)`
	`77`	`+ if outdated && isTTYOut(cmd) {`
	`78`	`+ _, _ = fmt.Fprintln(cmd.ErrOrStderr(), updateWorkspaceBanner)`
`79`	`79`	`}`
`80`	`80`
`81`	`81`	`// OpenSSH passes stderr directly to the calling TTY.`