chore: table formatter to correctly handle slices

Emyrk · Emyrk · commit b64c69b98a57 · 2024-06-12T11:01:29.000-05:00
diff --git a/cli/cliui/table.go b/cli/cliui/table.go
@@ -205,6 +205,21 @@ func renderTable(out any, sort string, headers table.Row, filterColumns []string
 				}
 			}
 
+			rt := reflect.TypeOf(v)
+			switch rt.Kind() {
+			case reflect.Slice:
+				// By default, the behavior is '%v', which just returns a string like
+				// '[a b c]'. This will add commas in between each value.
+				strs := make([]string, 0)
+				vt := reflect.ValueOf(v)
+				for i := 0; i < vt.Len(); i++ {
+					strs = append(strs, fmt.Sprintf("%v", vt.Index(i).Interface()))
+				}
+				v = "[" + strings.Join(strs, ", ") + "]"
+			default:
+				// Leave it as it is
+			}
+
 			rowSlice[i] = v
 		}
 
diff --git a/enterprise/cli/organizationmembers_test.go b/enterprise/cli/organizationmembers_test.go
@@ -15,7 +15,9 @@ import (
 	"github.com/coder/coder/v2/testutil"
 )
 
-func TestEnterpriseListOrganization(t *testing.T) {
+func TestEnterpriseListOrganizationMembers(t *testing.T) {
+	t.Parallel()
+
 	t.Run("CustomRole", func(t *testing.T) {
 		t.Parallel()
 
@@ -29,9 +31,11 @@ func TestEnterpriseListOrganization(t *testing.T) {
 				Features: license.Features{
 					codersdk.FeatureCustomRoles: 1,
 				},
-			}})
+			},
+		})
 
 		ctx := testutil.Context(t, testutil.WaitMedium)
+		//nolint:gocritic // only owners can patch roles
 		customRole, err := ownerClient.PatchOrganizationRole(ctx, owner.OrganizationID, codersdk.Role{
 			Name:            "custom",
 			OrganizationID:  owner.OrganizationID.String(),
@@ -47,7 +51,7 @@ func TestEnterpriseListOrganization(t *testing.T) {
 		client, user := coderdtest.CreateAnotherUser(t, ownerClient, owner.OrganizationID, rbac.RoleUserAdmin(), rbac.RoleIdentifier{
 			Name:           customRole.Name,
 			OrganizationID: owner.OrganizationID,
-		})
+		}, rbac.ScopedRoleOrgAdmin(owner.OrganizationID))
 
 		inv, root := clitest.New(t, "organization", "members", "-c", "user_id,username,organization_roles")
 		clitest.SetupConfig(t, client, root)
