ignore empty detail fields

Emyrk · Emyrk · commit b8bea993748a · 2024-08-19T08:50:42.000-05:00
diff --git a/site/src/api/errors.ts b/site/src/api/errors.ts
@@ -115,11 +115,14 @@ export const getErrorDetail = (error: unknown): string | undefined => {
 		return error.detail;
 	}
 
-	if (isApiError(error)) {
+	// APIErrors that are empty still benefit from checking the
+	// developer console if no detail is provided. So only use the
+	// detail field if it is not empty.
+	if (isApiError(error) && error.response.data.detail) {
 		return error.response.data.detail;
 	}
 
-	if (isApiErrorResponse(error)) {
+	if (isApiErrorResponse(error) && error.detail) {
 		return error.detail;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -115,11 +115,14 @@ export const getErrorDetail = (error: unknown): string \| undefined => {`
`115`	`115`	`return error.detail;`
`116`	`116`	`}`
`117`	`117`
`118`		`- if (isApiError(error)) {`
	`118`	`+ // APIErrors that are empty still benefit from checking the`
	`119`	`+ // developer console if no detail is provided. So only use the`
	`120`	`+ // detail field if it is not empty.`
	`121`	`+ if (isApiError(error) && error.response.data.detail) {`
`119`	`122`	`return error.response.data.detail;`
`120`	`123`	`}`
`121`	`124`
`122`		`- if (isApiErrorResponse(error)) {`
	`125`	`+ if (isApiErrorResponse(error) && error.detail) {`
`123`	`126`	`return error.detail;`
`124`	`127`	`}`
`125`	`128`