fix: check for nil pointer in AwaitWorkspaceAgents

spikecurtis · web-flow · commit b9c7bc4d3ca2 · 2023-10-09T22:12:28.000+04:00
CompletedAt is a pointer and can be nil, need to check before calling IsZero() on it c.f. https://github.com/coder/coder/runs/17534657301
diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go
@@ -857,6 +857,9 @@ func AwaitWorkspaceAgents(t testing.TB, client *codersdk.Client, workspaceID uui
 		if !assert.NoError(t, err) {
 			return false
 		}
+		if workspace.LatestBuild.Job.CompletedAt == nil {
+			return false
+		}
 		if workspace.LatestBuild.Job.CompletedAt.IsZero() {
 			return false
 		}

Original file line number	Diff line number	Diff line change
`@@ -857,6 +857,9 @@ func AwaitWorkspaceAgents(t testing.TB, client *codersdk.Client, workspaceID uui`
`857`	`857`	`if !assert.NoError(t, err) {`
`858`	`858`	`return false`
`859`	`859`	`}`
	`860`	`+ if workspace.LatestBuild.Job.CompletedAt == nil {`
	`861`	`+ return false`
	`862`	`+ }`
`860`	`863`	`if workspace.LatestBuild.Job.CompletedAt.IsZero() {`
`861`	`864`	`return false`
`862`	`865`	`}`