feat: Add success messages for CLI commands (#2634)

AbhineetJain · web-flow · commit bd07284a680c · 2022-06-24T16:30:22.000Z
diff --git a/cli/delete.go b/cli/delete.go
@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/spf13/cobra"
@@ -41,7 +42,14 @@ func delete() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			return cliui.WorkspaceBuild(cmd.Context(), cmd.OutOrStdout(), client, build.ID, before)
+
+			err = cliui.WorkspaceBuild(cmd.Context(), cmd.OutOrStdout(), client, build.ID, before)
+			if err != nil {
+				return err
+			}
+
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nThe %s workspace has been deleted!\n", cliui.Styles.Keyword.Render(workspace.Name))
+			return nil
 		},
 	}
 	cliui.AllowSkipPrompt(cmd)
diff --git a/cli/resetpassword.go b/cli/resetpassword.go
@@ -2,6 +2,7 @@ package cli
 
 import (
 	"database/sql"
+	"fmt"
 
 	"github.com/spf13/cobra"
 	"golang.org/x/xerrors"
@@ -80,6 +81,7 @@ func resetPassword() *cobra.Command {
 				return xerrors.Errorf("updating password: %w", err)
 			}
 
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nPassword has been reset for user %s!\n", cliui.Styles.Keyword.Render(user.Username))
 			return nil
 		},
 	}
diff --git a/cli/start.go b/cli/start.go
@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/spf13/cobra"
@@ -39,7 +40,14 @@ func start() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			return cliui.WorkspaceBuild(cmd.Context(), cmd.OutOrStdout(), client, build.ID, before)
+
+			err = cliui.WorkspaceBuild(cmd.Context(), cmd.OutOrStdout(), client, build.ID, before)
+			if err != nil {
+				return err
+			}
+
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nThe %s workspace has been started!\n", cliui.Styles.Keyword.Render(workspace.Name))
+			return nil
 		},
 	}
 	cliui.AllowSkipPrompt(cmd)
diff --git a/cli/stop.go b/cli/stop.go
@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/spf13/cobra"
@@ -39,7 +40,14 @@ func stop() *cobra.Command {
 			if err != nil {
 				return err
 			}
-			return cliui.WorkspaceBuild(cmd.Context(), cmd.OutOrStdout(), client, build.ID, before)
+
+			err = cliui.WorkspaceBuild(cmd.Context(), cmd.OutOrStdout(), client, build.ID, before)
+			if err != nil {
+				return err
+			}
+
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nThe %s workspace has been stopped!\n", cliui.Styles.Keyword.Render(workspace.Name))
+			return nil
 		},
 	}
 	cliui.AllowSkipPrompt(cmd)
diff --git a/cli/userstatus.go b/cli/userstatus.go
@@ -13,15 +13,18 @@ import (
 // createUserStatusCommand sets a user status.
 func createUserStatusCommand(sdkStatus codersdk.UserStatus) *cobra.Command {
 	var verb string
+	var pastVerb string
 	var aliases []string
 	var short string
 	switch sdkStatus {
 	case codersdk.UserStatusActive:
 		verb = "activate"
+		pastVerb = "activated"
 		aliases = []string{"active"}
 		short = "Update a user's status to 'active'. Active users can fully interact with the platform"
 	case codersdk.UserStatusSuspended:
 		verb = "suspend"
+		pastVerb = "suspended"
 		aliases = []string{"rm", "delete"}
 		short = "Update a user's status to 'suspended'. A suspended user cannot log into the platform"
 	default:
@@ -76,6 +79,8 @@ func createUserStatusCommand(sdkStatus codersdk.UserStatus) *cobra.Command {
 			if err != nil {
 				return xerrors.Errorf("%s user: %w", verb, err)
 			}
+
+			_, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nUser %s has been %s!\n", cliui.Styles.Keyword.Render(user.Username), pastVerb)
 			return nil
 		},
 	}

Original file line number	Diff line number	Diff line change
`@@ -2,6 +2,7 @@ package cli`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"database/sql"`
	`5`	`+ "fmt"`
`5`	`6`
`6`	`7`	`"github.com/spf13/cobra"`
`7`	`8`	`"golang.org/x/xerrors"`
`@@ -80,6 +81,7 @@ func resetPassword() *cobra.Command {`
`80`	`81`	`return xerrors.Errorf("updating password: %w", err)`
`81`	`82`	`}`
`82`	`83`
	`84`	`+ _, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nPassword has been reset for user %s!\n", cliui.Styles.Keyword.Render(user.Username))`
`83`	`85`	`return nil`
`84`	`86`	`},`
`85`	`87`	`}`