Skip to content

Commit c2e3648

Browse files
authored
fix: disable tests broken by daylight savings (#10414)
1 parent 3b50530 commit c2e3648

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

codersdk/deployment_test.go

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -209,25 +209,26 @@ func TestTimezoneOffsets(t *testing.T) {
209209
ExpectedOffset int
210210
}{
211211
{
212-
Name: "UTX",
212+
Name: "UTC",
213213
Loc: time.UTC,
214214
ExpectedOffset: 0,
215215
},
216-
{
217-
Name: "Eastern",
218-
Loc: must(time.LoadLocation("America/New_York")),
219-
ExpectedOffset: -4,
220-
},
221-
{
222-
Name: "Central",
223-
Loc: must(time.LoadLocation("America/Chicago")),
224-
ExpectedOffset: -5,
225-
},
226-
{
227-
Name: "Ireland",
228-
Loc: must(time.LoadLocation("Europe/Dublin")),
229-
ExpectedOffset: 1,
230-
},
216+
// The following test cases are broken re: daylight savings
217+
//{
218+
// Name: "Eastern",
219+
// Loc: must(time.LoadLocation("America/New_York")),
220+
// ExpectedOffset: -4,
221+
//},
222+
//{
223+
// Name: "Central",
224+
// Loc: must(time.LoadLocation("America/Chicago")),
225+
// ExpectedOffset: -5,
226+
//},
227+
//{
228+
// Name: "Ireland",
229+
// Loc: must(time.LoadLocation("Europe/Dublin")),
230+
// ExpectedOffset: 1,
231+
//},
231232
{
232233
Name: "HalfHourTz",
233234
// This timezone is +6:30, but the function rounds to the nearest hour.

0 commit comments

Comments
 (0)