Current dependencies on/for this PR:

• main
  • PR fix: disable tests broken by daylight savings #10414 👈

This comment was auto-generated by Graphite.

Oof. So either need to find locations without daylight savings or detect it and change the test accordingly?

Oof. So either need to find locations without daylight savings or detect it and change the test accordingly?

The other thought I had is to make that function also take the time.Time, which would be time.Now() in production, but could be a known time with a known offset in tests.

Anyway, what real value are we getting by asserting particular US/Ireland location offsets? Could also just replace those commented out test cases with Abu Dhabi and call it a day.

Yea, I started the refactor to pass in a time, I also uses time.Time.IsDST() to adjust the test to allow DST to pass.

In the end though, the refactor to pass in a time kinda makes the function api a little strange since the time.Time has a .Location(), and you also pass in a time.Location?

In the end this is for insights to make sure the data is relative to the user's local timezone, and the buckets are daily. So I stopped spending time on getting the tests to be "perfect". 🤷