Parallelize tests

Emyrk · Emyrk · commit c2eec183e03c · 2022-04-04T10:12:46.000-05:00
diff --git a/coderd/authz/authz_test.go b/coderd/authz/authz_test.go
@@ -12,6 +12,8 @@ import (
 var nilSet = authztest.Set{nil}
 
 func Test_ExhaustiveAuthorize(t *testing.T) {
+	t.Parallel()
+
 	all := authztest.GroupedPermissions(authztest.AllPermissions())
 	roleVariants := permissionVariants(all)
 	res := authz.ResourceType(authztest.PermObjectType).AsID(authztest.PermObjectID)
diff --git a/coderd/authz/authztest/iterator_test.go b/coderd/authz/authztest/iterator_test.go
@@ -11,6 +11,8 @@ import (
 )
 
 func TestUnion(t *testing.T) {
+	t.Parallel()
+
 	for i := 0; i < 100; i++ {
 		allPerms := make(authztest.Set, 0)
 		// 2 - 4 sets
diff --git a/coderd/authz/authztest/level_test.go b/coderd/authz/authztest/level_test.go
@@ -9,6 +9,8 @@ import (
 )
 
 func Test_GroupedPermissions(t *testing.T) {
+	t.Parallel()
+
 	set := make(authztest.Set, 0)
 	var total int
 	for _, lvl := range authz.PermissionLevels {
@@ -86,5 +88,4 @@ func Test_GroupedPermissions(t *testing.T) {
 			require.Equal(t, c.ExpAbs, len(c.Lvl.Abstain()), "correct num abs")
 		})
 	}
-
 }
diff --git a/coderd/authz/authztest/permissions_test.go b/coderd/authz/authztest/permissions_test.go
@@ -8,6 +8,8 @@ import (
 )
 
 func Test_AllPermissions(t *testing.T) {
+	t.Parallel()
+
 	// If this changes, then we might have to fix some other tests. This constant
 	// is the basis for understanding the permutation counts.
 	const totalUniquePermissions int = 270
diff --git a/coderd/authz/authztest/set_test.go b/coderd/authz/authztest/set_test.go
@@ -10,7 +10,11 @@ import (
 )
 
 func Test_Set(t *testing.T) {
+	t.Parallel()
+
 	t.Run("Simple", func(t *testing.T) {
+		t.Parallel()
+
 		for i := 0; i < 10; i++ {
 			set := RandomSet(i)
 			require.Equal(t, i, len(set), "set size")
@@ -23,6 +27,8 @@ func Test_Set(t *testing.T) {
 	})
 
 	t.Run("NilPerms", func(t *testing.T) {
+		t.Parallel()
+
 		for i := 0; i < 100; i++ {
 			set := RandomSet(i)
 			// Set some nils
@@ -38,6 +44,8 @@ func Test_Set(t *testing.T) {
 	})
 
 	t.Run("String", func(t *testing.T) {
+		t.Parallel()
+
 		set := authztest.Set{
 			&authz.Permission{
 				Sign:         true,
diff --git a/coderd/authz/permission_test.go b/coderd/authz/permission_test.go
@@ -4,11 +4,12 @@ import (
 	"testing"
 
 	"github.com/coder/coder/coderd/authz"
-	crand "github.com/coder/coder/cryptorand"
 	"github.com/stretchr/testify/require"
 )
 
 func Test_PermissionString(t *testing.T) {
+	t.Parallel()
+
 	testCases := []struct {
 		Name       string
 		Permission authz.Permission
@@ -59,41 +60,3 @@ func Test_PermissionString(t *testing.T) {
 	}
 
 }
-
-func BenchmarkPermissionString(b *testing.B) {
-	total := 10000
-	if b.N < total {
-		total = b.N
-	}
-	perms := make([]authz.Permission, b.N)
-	for n := 0; n < total; n++ {
-		perms[n] = RandomPermission()
-	}
-
-	b.ResetTimer()
-	for n := 0; n < b.N; n++ {
-		var _ = perms[n%total].String()
-	}
-}
-
-var resourceTypes = []authz.ResourceType{
-	"project", "config", "user", "user_role",
-	"workspace", "dev-url", "metric", "*",
-}
-
-var actions = []authz.Action{
-	"read", "create", "delete", "modify", "*",
-}
-
-func RandomPermission() authz.Permission {
-	n, _ := crand.Intn(len(authz.PermissionLevels))
-	m, _ := crand.Intn(len(resourceTypes))
-	a, _ := crand.Intn(len(actions))
-	return authz.Permission{
-		Sign:         n%2 == 0,
-		Level:        authz.PermissionLevels[n],
-		ResourceType: resourceTypes[m],
-		ResourceID:   "*",
-		Action:       actions[a],
-	}
-}

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,8 @@ import (`
`11`	`11`	`)`
`12`	`12`
`13`	`13`	`func TestUnion(t *testing.T) {`
	`14`	`+ t.Parallel()`
	`15`	`+`
`14`	`16`	`for i := 0; i < 100; i++ {`
`15`	`17`	`allPerms := make(authztest.Set, 0)`
`16`	`18`	`// 2 - 4 sets`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,8 @@ import (`
`9`	`9`	`)`
`10`	`10`
`11`	`11`	`func Test_GroupedPermissions(t *testing.T) {`
	`12`	`+ t.Parallel()`
	`13`	`+`
`12`	`14`	`set := make(authztest.Set, 0)`
`13`	`15`	`var total int`
`14`	`16`	`for _, lvl := range authz.PermissionLevels {`
`@@ -86,5 +88,4 @@ func Test_GroupedPermissions(t *testing.T) {`
`86`	`88`	`require.Equal(t, c.ExpAbs, len(c.Lvl.Abstain()), "correct num abs")`
`87`	`89`	`})`
`88`	`90`	`}`
`89`		`-`
`90`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,8 @@ import (`
`8`	`8`	`)`
`9`	`9`
`10`	`10`	`func Test_AllPermissions(t *testing.T) {`
	`11`	`+ t.Parallel()`
	`12`	`+`
`11`	`13`	`// If this changes, then we might have to fix some other tests. This constant`
`12`	`14`	`// is the basis for understanding the permutation counts.`
`13`	`15`	`const totalUniquePermissions int = 270`