fix: update tests/stories

Parkreiner · Parkreiner · commit c69b449a3e6a · 2025-08-13T21:17:37.000Z
diff --git a/site/src/components/Abbr/Abbr.stories.tsx b/site/src/components/Abbr/Abbr.stories.tsx
@@ -6,10 +6,10 @@ const meta: Meta<typeof Abbr> = {
 	component: Abbr,
 	decorators: [
 		(Story) => (
-			<>
+			<div className="max-w-prose text-base">
 				<p>Try the following text out in a screen reader!</p>
 				<Story />
-			</>
+			</div>
 		),
 	],
 };
@@ -25,9 +25,9 @@ export const InlinedShorthand: Story = {
 	},
 	decorators: [
 		(Story) => (
-			<p className="max-w-2xl">
+			<p>
 				The physical pain of getting bonked on the head with a cartoon mallet
-				lasts precisely 593{" "}
+				lasts precisely 593
 				<span className="underline decoration-dotted">
 					<Story />
 				</span>
diff --git a/site/src/components/Abbr/Abbr.test.tsx b/site/src/components/Abbr/Abbr.test.tsx
@@ -8,7 +8,7 @@ type AbbreviationData = {
 };
 
 describe(Abbr.name, () => {
-	it("Has an aria-label that equals the title if the abbreviation is shorthand", () => {
+	it("Omits abbreviation from screen-reader output if it is shorthand", () => {
 		const sampleShorthands: AbbreviationData[] = [
 			{
 				abbreviation: "ms",
@@ -38,7 +38,7 @@ describe(Abbr.name, () => {
 		}
 	});
 
-	it("Has an aria label with title and 'flattened' pronunciation if abbreviation is acronym", () => {
+	it("Adds title and 'flattened' pronunciation if abbreviation is acronym", () => {
 		const sampleAcronyms: AbbreviationData[] = [
 			{
 				abbreviation: "NASA",
@@ -70,7 +70,7 @@ describe(Abbr.name, () => {
 		}
 	});
 
-	it("Has an aria label with title and initialized pronunciation if abbreviation is initialism", () => {
+	it("Adds title and initialized pronunciation if abbreviation is initialism", () => {
 		const sampleInitialisms: AbbreviationData[] = [
 			{
 				abbreviation: "FBI",
diff --git a/site/src/components/Abbr/Abbr.tsx b/site/src/components/Abbr/Abbr.tsx
@@ -33,10 +33,8 @@ export const Abbr: FC<AbbrProps> = ({
 			// to inject the actual text content inside the abbr itself
 			title={title}
 			className={cn(
-				"underline-none",
-				children === children.toUpperCase()
-					? "tracking-wide"
-					: "tracking-normal",
+				"no-underline tracking-normal",
+				children === children.toUpperCase() && "tracking-wide",
 				className,
 			)}
 			{...delegatedProps}

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ type AbbreviationData = {`
`8`	`8`	`};`
`9`	`9`
`10`	`10`	`describe(Abbr.name, () => {`
`11`		`- it("Has an aria-label that equals the title if the abbreviation is shorthand", () => {`
	`11`	`+ it("Omits abbreviation from screen-reader output if it is shorthand", () => {`
`12`	`12`	`const sampleShorthands: AbbreviationData[] = [`
`13`	`13`	`{`
`14`	`14`	`abbreviation: "ms",`
`@@ -38,7 +38,7 @@ describe(Abbr.name, () => {`
`38`	`38`	`}`
`39`	`39`	`});`
`40`	`40`
`41`		`- it("Has an aria label with title and 'flattened' pronunciation if abbreviation is acronym", () => {`
	`41`	`+ it("Adds title and 'flattened' pronunciation if abbreviation is acronym", () => {`
`42`	`42`	`const sampleAcronyms: AbbreviationData[] = [`
`43`	`43`	`{`
`44`	`44`	`abbreviation: "NASA",`
`@@ -70,7 +70,7 @@ describe(Abbr.name, () => {`
`70`	`70`	`}`
`71`	`71`	`});`
`72`	`72`
`73`		`- it("Has an aria label with title and initialized pronunciation if abbreviation is initialism", () => {`
	`73`	`+ it("Adds title and initialized pronunciation if abbreviation is initialism", () => {`
`74`	`74`	`const sampleInitialisms: AbbreviationData[] = [`
`75`	`75`	`{`
`76`	`76`	`abbreviation: "FBI",`