avoid resetting container in recreate

mafredri · mafredri · commit c8a5bb8f8a4a · 2025-05-16T11:59:23.000Z
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -511,7 +511,13 @@ func (api *API) handleDevcontainerRecreate(w http.ResponseWriter, r *http.Reques
 						slog.F("name", api.knownDevcontainers[i].Name),
 					)
 					api.knownDevcontainers[i].Dirty = false
+					// TODO(mafredri): This should be handled by a service that
+					// updates the devcontainer state periodically and on-demand.
 					api.knownDevcontainers[i].Container = nil
+					// Set the modified time to the zero value to indicate that
+					// the containers list must be refreshed. This will see to
+					// it that the new container is re-assigned.
+					api.mtime = time.Time{}
 				}
 				return
 			}

Original file line number	Diff line number	Diff line change
`@@ -511,7 +511,13 @@ func (api API) handleDevcontainerRecreate(w http.ResponseWriter, r http.Reques`
`511`	`511`	`slog.F("name", api.knownDevcontainers[i].Name),`
`512`	`512`	`)`
`513`	`513`	`api.knownDevcontainers[i].Dirty = false`
	`514`	`+ // TODO(mafredri): This should be handled by a service that`
	`515`	`+ // updates the devcontainer state periodically and on-demand.`
`514`	`516`	`api.knownDevcontainers[i].Container = nil`
	`517`	`+ // Set the modified time to the zero value to indicate that`
	`518`	`+ // the containers list must be refreshed. This will see to`
	`519`	`+ // it that the new container is re-assigned.`
	`520`	`+ api.mtime = time.Time{}`
`515`	`521`	`}`
`516`	`522`	`return`
`517`	`523`	`}`