feat: disable stop button during loading to prevent duplicate clicks

blink-so[bot] · matifali · blink-so[bot] · commit cb3396327ebb · 2025-06-13T20:13:04.000Z
- Add disabled prop to PrimaryActionProps interface
- Implement disabled state in PrimaryAction component
- Apply disabled prop to stop button when stopWorkspaceMutation is pending
- Prevents accidental duplicate stop requests during operation

Co-authored-by: matifali &lt;10648092+matifali@users.noreply.github.com&gt;
diff --git a/site/src/pages/WorkspacesPage/WorkspacesTable.tsx b/site/src/pages/WorkspacesPage/WorkspacesTable.tsx
@@ -545,6 +545,7 @@ const WorkspaceActionsCell: FC<WorkspaceActionsCellProps> = ({
 					<PrimaryAction
 						onClick={() => setIsStopConfirmOpen(true)}
 						isLoading={stopWorkspaceMutation.isPending}
+						disabled={stopWorkspaceMutation.isPending}
 						label="Stop workspace"
 					>
 						<SquareIcon />
@@ -611,20 +612,27 @@ const WorkspaceActionsCell: FC<WorkspaceActionsCellProps> = ({
 type PrimaryActionProps = PropsWithChildren<{
 	label: string;
 	isLoading?: boolean;
+	disabled?: boolean;
 	onClick: () => void;
 }>;
 
 const PrimaryAction: FC<PrimaryActionProps> = ({
 	onClick,
 	isLoading,
+	disabled,
 	label,
 	children,
 }) => {
 	return (
 		<TooltipProvider>
 			<Tooltip>
 				<TooltipTrigger asChild>
-					<Button variant="outline" size="icon-lg" onClick={onClick}>
+					<Button
+						variant="outline"
+						size="icon-lg"
+						onClick={onClick}
+						disabled={disabled}
+					>
 						<Spinner loading={isLoading}>{children}</Spinner>
 						<span className="sr-only">{label}</span>
 					</Button>
