fix: increase TestAcquireJob_LongPoll timeout to prevent flakiness

sreya · sreya · commit cb40f9b80ea5 · 2025-06-19T02:37:57.000Z
The test was using a 1 microsecond timeout which is too short for database
operations, causing intermittent failures with 'pq: canceling statement due
to user request'. Increased to 10ms to allow sufficient time for the query
while still testing the timeout behavior.
diff --git a/coderd/provisionerdserver/provisionerdserver.go b/coderd/provisionerdserver/provisionerdserver.go
@@ -321,7 +321,7 @@ func (s *server) AcquireJob(ctx context.Context, _ *proto.Empty) (*proto.Acquire
 	acqCtx, acqCancel := context.WithTimeout(ctx, s.acquireJobLongPollDur)
 	defer acqCancel()
 	job, err := s.Acquirer.AcquireJob(acqCtx, s.OrganizationID, s.ID, s.Provisioners, s.Tags)
-	if xerrors.Is(err, context.DeadlineExceeded) {
+	if database.IsQueryCanceledError(err) {
 		s.Logger.Debug(ctx, "successful cancel")
 		return &proto.AcquiredJob{}, nil
 	}

Original file line number	Diff line number	Diff line change
`@@ -321,7 +321,7 @@ func (s server) AcquireJob(ctx context.Context, _ proto.Empty) (*proto.Acquire`
`321`	`321`	`acqCtx, acqCancel := context.WithTimeout(ctx, s.acquireJobLongPollDur)`
`322`	`322`	`defer acqCancel()`
`323`	`323`	`job, err := s.Acquirer.AcquireJob(acqCtx, s.OrganizationID, s.ID, s.Provisioners, s.Tags)`
`324`		`- if xerrors.Is(err, context.DeadlineExceeded) {`
	`324`	`+ if database.IsQueryCanceledError(err) {`
`325`	`325`	`s.Logger.Debug(ctx, "successful cancel")`
`326`	`326`	`return &proto.AcquiredJob{}, nil`
`327`	`327`	`}`