fix: show preset parameters when they have diagnostics

blink-so[bot] · blink-so[bot] · commit cb52c2c7f1b1 · 2025-06-05T18:44:08.000Z
Always show preset parameters in CreateWorkspacePageViewExperimental if the preset parameter has any diagnostics, regardless of the showPresetParameters toggle state. Fixes #651
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
@@ -621,7 +621,9 @@ export const CreateWorkspacePageViewExperimental: FC<
 										isPresetParameter;
 
 									// Hide preset parameters if showPresetParameters is false
-									if (!showPresetParameters && isPresetParameter) {
+									// Always show preset parameters if they have any diagnostics
+									const hasParameterDiagnostics = parameter.diagnostics.length > 0;
+									if (!showPresetParameters && isPresetParameter && !hasParameterDiagnostics) {
 										return null;
 									}
 

Original file line number	Diff line number	Diff line change
`@@ -621,7 +621,9 @@ export const CreateWorkspacePageViewExperimental: FC<`
`621`	`621`	`isPresetParameter;`
`622`	`622`
`623`	`623`	`// Hide preset parameters if showPresetParameters is false`
`624`		`- if (!showPresetParameters && isPresetParameter) {`
	`624`	`+ // Always show preset parameters if they have any diagnostics`
	`625`	`+ const hasParameterDiagnostics = parameter.diagnostics.length > 0;`
	`626`	`+ if (!showPresetParameters && isPresetParameter && !hasParameterDiagnostics) {`
`625`	`627`	`return null;`
`626`	`628`	`}`
`627`	`629`