add ruleguard for pty.Command

sreya · sreya · commit cb70b0798749 · 2024-11-21T21:21:12.000Z
diff --git a/scripts/rules.go b/scripts/rules.go
@@ -498,6 +498,20 @@ func noExecInAgent(m dsl.Matcher) {
 		`exec.Command($*_)`,
 		`exec.CommandContext($*_)`,
 	).
-		Where(m.File().PkgPath.Matches("^github.com/coder/coder/agent")).
+		Where(m.File().PkgPath.Matches("/agent/")).
 		Report("The agent and its subpackages should not use exec.Command or exec.CommandContext directly. Consider using agentexec.CommandContext instead.")
 }
+
+// noPTYInAgent ensures that packages under agent/ don't use pty.Command or
+// pty.CommandContext directly.
+//
+//nolint:unused,deadcode,varnamelen
+func noPTYInAgent(m dsl.Matcher) {
+	m.Import("github.com/coder/coder/v2/pty")
+	m.Match(
+		`pty.Command($*_)`,
+		`pty.CommandContext($*_)`,
+	).
+		Where(m.File().PkgPath.Matches(`/agent/`)).
+		Report("The agent and its subpackages should not use pty.Command or pty.CommandContext directly. Consider using agentexec.PTYCommandContext instead.")
+}
