warn rather than fail if module archival results in an error

aslilac · aslilac · commit cbc8035d9df8 · 2025-05-08T17:42:21.000Z
diff --git a/provisioner/terraform/executor.go b/provisioner/terraform/executor.go
@@ -309,7 +309,8 @@ func (e *executor) plan(ctx, killCtx context.Context, env, vars []string, logr l
 
 	moduleFiles, err := getModulesArchive(e.workdir)
 	if err != nil {
-		return nil, err
+		// TODO: we probably want to persist this error or make it louder eventually
+		e.logger.Warn(ctx, "failed to archive terraform modules", slog.Error(err))
 	}
 
 	return &proto.PlanComplete{

Original file line number	Diff line number	Diff line change
`@@ -309,7 +309,8 @@ func (e *executor) plan(ctx, killCtx context.Context, env, vars []string, logr l`
`309`	`309`
`310`	`310`	`moduleFiles, err := getModulesArchive(e.workdir)`
`311`	`311`	`if err != nil {`
`312`		`- return nil, err`
	`312`	`+ // TODO: we probably want to persist this error or make it louder eventually`
	`313`	`+ e.logger.Warn(ctx, "failed to archive terraform modules", slog.Error(err))`
`313`	`314`	`}`
`314`	`315`
`315`	`316`	`return &proto.PlanComplete{`