Improve logging via slog.Helper()

mafredri · mafredri · commit cdf01f8a5f4c · 2023-02-22T13:29:11.000Z
diff --git a/tailnet/conn.go b/tailnet/conn.go
@@ -815,6 +815,7 @@ func (a addr) String() string  { return a.ln.addr }
 // Logger converts the Tailscale logging function to use slog.
 func Logger(logger slog.Logger) tslogger.Logf {
 	return tslogger.Logf(func(format string, args ...any) {
+		slog.Helper()
 		logger.Debug(context.Background(), fmt.Sprintf(format, args...))
 	})
 }

Original file line number	Diff line number	Diff line change
`@@ -815,6 +815,7 @@ func (a addr) String() string { return a.ln.addr }`
`815`	`815`	`// Logger converts the Tailscale logging function to use slog.`
`816`	`816`	`func Logger(logger slog.Logger) tslogger.Logf {`
`817`	`817`	`return tslogger.Logf(func(format string, args ...any) {`
	`818`	`+ slog.Helper()`
`818`	`819`	`logger.Debug(context.Background(), fmt.Sprintf(format, args...))`
`819`	`820`	`})`
`820`	`821`	`}`